Filter sidebar shares for displayName #9504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
reviewed
Aug 10, 2023
Comment on lines
201
to
214
| return [...this.outgoingCollaborators] | ||
| .filter((c) => c.collaborator.displayName) | ||
| .sort(this.collaboratorsComparator) | ||
| .map((c) => { | ||
| const collaborator: typeof c & { key?: string; resharers?: User[] } = { ...c } | ||
| collaborator.key = 'collaborator-' + collaborator.id | ||
| if ( | ||
| collaborator.owner.name !== collaborator.fileOwner.name && | ||
| collaborator.owner.name !== this.user.id | ||
| ) { | ||
| collaborator.resharers = [collaborator.owner] | ||
| } | ||
| return collaborator | ||
| }) |
There was a problem hiding this comment.
I'd prefer adding the filter to outgoingCollaborators in our useShare composable.
I guess this is CERN specific? We can also think about overwriting the composable via cern config like we did here. Although it's such a small change, it's probably not worth the effort 🤔
There was a problem hiding this comment.
I'm open to doing that, the benefit of doing it here is that one could also add some sort of hint to the UI about further shares existing but the webUI not being able to correctly render these (whcih technically could also be done inside the composable and then exported, ofc). Let me discuss this with @tbsbdr
pascalwengerter
force-pushed
the
bugfix/9257
branch
from
5d24e3d to
d8d609d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
JammingBen
approved these changes
Aug 15, 2023
ownclouders
pushed a commit
that referenced
this pull request
Aug 16, 2023
* Fix #9257 * Move filtering for collaborator displayName in outgoingShares to useShares composable
AlexAndBear
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Fix #9257 * Move filtering for collaborator displayName in outgoingShares to useShares composable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue