Skip to content

Commit

Permalink
Merge pull request #3808 from owncloud/pmaier1-haxx-1
Browse files Browse the repository at this point in the history
Remove "Shared with:" from file list rows
  • Loading branch information
kulmann authored Jul 24, 2020
2 parents 460211c + 99a4532 commit ae6ab00
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
9 changes: 5 additions & 4 deletions apps/files/src/components/FileItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,14 @@
v-text="'.' + item.extension"
/>
</div>
<div v-if="hasTwoRows" class="uk-flex uk-flex-middle">
<translate class="uk-margin-small-right">Shared with:</translate>
<div v-if="hasTwoRows && hasIndicators" class="uk-flex uk-flex-middle">
<Indicators
v-if="indicators.length > 0"
key="status-indicators"
:default-indicators="indicators"
:item="item"
:are-indicators-clickable="areIndicatorsClickable"
class="files-list-indicators"
/>
<span v-else key="no-status-indicators" aria-hidden="true" v-text="'-'" />
</div>
</div>
</div>
Expand Down Expand Up @@ -133,6 +130,10 @@ export default {
davUrl = ['..', 'dav', 'files', this.$store.getters.user.id].join('/')
}
return this.$client.files.getFileUrl(davUrl)
},
hasIndicators() {
return this.indicators.length > 0
}
},
mounted() {
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/remove-shared-with
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Change: Get rid of static "Shared with:" label

We removed the static "Shared with:" text label in the indicator row of file items. From now on, if a file item has no indicators, it will fall back to the one-row layout (resource name vertically centered).

https://github.com/owncloud/product/issues/123
https://github.com/owncloud/phoenix/pull/3808

0 comments on commit ae6ab00

Please sign in to comment.