Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Shared with:" from file list rows #3808

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Remove "Shared with:" from file list rows #3808

merged 3 commits into from
Jul 24, 2020

Conversation

pmaier1
Copy link
Contributor

@pmaier1 pmaier1 commented Jul 22, 2020

;)

Please check whether that works ^_^

Closes owncloud/product#123
Closes owncloud/ocis#408

@pmaier1 pmaier1 requested a review from LukasHirt July 22, 2020 07:59
@pmaier1 pmaier1 self-assigned this Jul 22, 2020
@update-docs
Copy link

update-docs bot commented Jul 22, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pmaier1 pmaier1 requested a review from kulmann July 22, 2020 07:59
@kulmann
Copy link
Member

kulmann commented Jul 22, 2020

Margins are looking good.
Screenshot 2020-07-22 at 10 03 34

However, I'm just thinking if we should default back to the "one line" row layout if there are no indicators, instead of showing the -. This is how it looks now:
Screenshot 2020-07-22 at 10 02 59

@kulmann
Copy link
Member

kulmann commented Jul 22, 2020

Screenshot 2020-07-22 at 10 12 49

@pmaier1 ^ this is what it would look like with one row for files without indicators.

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2020

CLA assistant check
All committers have signed the CLA.

@kulmann kulmann requested a review from refs July 23, 2020 13:28
@kulmann
Copy link
Member

kulmann commented Jul 23, 2020

@refs could you review this? then we can merge and include it in the release...

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

@kulmann kulmann merged commit ae6ab00 into master Jul 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the pmaier1-haxx-1 branch July 24, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Useless 'Shared with:-' indicators dominate the GUI Changes to file list: "Shared with"
4 participants