refactor: remove opinionated components from ODS #10293
Conversation
JammingBen
force-pushed
the
move-opinionated-resource-components-to-pkg
branch
2 times, most recently
from
b04e7f3 to
c09a296
Compare
packages/design-system/changelog/unreleased/change-remove-opinionated-components
Outdated
Show resolved
Hide resolved
packages/design-system/changelog/unreleased/change-remove-opinionated-components
Show resolved
Hide resolved
There was a problem hiding this comment.
Move into subfolder FilesList? The ResourceTiles.vue component still lives in the files app, but it would make sense to move it here into the FilesList folder anyway... if you think the scope of this PR can handle that move as well, then go for it 😇
There was a problem hiding this comment.
Moving ResourceTiles.vue is a little more work to do, I created an issue for this: #10304
There was a problem hiding this comment.
Since this component now moved from the (potentially standalone) design system into web-pkg we don't need to provide/inject the icon mappings anymore. Instead the component could query that from the runtime / a composable / whatever. But maybe something for a followup... could you create an issue? Or just add a todo in your PR description, so that I can create the issue before we merge and after we agreed that we want to change it. 😅
There was a problem hiding this comment.
Good catch, I've created #10305 for this.
|
|
I decided for |
Removes the following opinionated components from the ODS and moves them to `web-pkg` instead: - `OcResource` (now `ResourceListItem`) - `OcTile` (now `ResourceTile`) - `OcResourceIcon` (now `ResourceIcon`) - `OcGhostElement` (now `DragGhostElement`) Those components hold logic about resources, which is something that is not supposed to live in the ODS. The ODS should only contain design- and layout-specific components.
Move the following components to web-pkg: - `OcResourceLink` (now `ResourceLink`) - `OcResourceName` (now `ResourceName`) - `OcResourceSize` (now `ResourceSize`)
JammingBen
force-pushed
the
move-opinionated-resource-components-to-pkg
branch
from
da34479 to
e43c9f8
Compare
|
delete-merged-branch
bot
deleted the
move-opinionated-resource-components-to-pkg
branch
Description
Removes the following opinionated components from the ODS and moves them to
web-pkginstead:OcResource(nowResourceListItem)OcTile(nowResourceTile)OcResourceIcon(nowResourceIcon)OcGhostElement(nowResourceGhostElement)OcResourceLink(nowResourceLink)OcResourceName(nowResourceName)OcResourceSize(nowResourceSize)Those components hold logic about resources, which is something that is not supposed to live in the ODS. The ODS should only contain design- and layout-specific components.
Types of changes