Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] test(e2e): create and download file having comma #10447

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Feb 6, 2024

Description

Added e2e test to create and download a file containing comma in its name.
Removed these acceptance tests:

Scenario: create file with name that contains commas
When the user creates a file with the name "sample,1.txt" using the webUI
And the user browses to the files page
Then file "sample,1.txt" should be listed on the webUI

and
Scenario: download file with comma in the filename
Given user "Alice" has created file "sample,1.txt" in the server
And user "Alice" has logged in using the webUI
When the user downloads file "sample,1.txt" using the webUI
Then no message should be displayed on the webUI

Related Issue

Coverage for:

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • require ocis bump

@saw-jan saw-jan added the QA:team label Feb 6, 2024
@saw-jan saw-jan self-assigned this Feb 6, 2024
@saw-jan saw-jan force-pushed the tests/create-file-with-comma branch from 2141865 to ce62563 Compare February 8, 2024 08:37
@saw-jan saw-jan marked this pull request as ready for review February 8, 2024 08:56
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 04471c0 into master Feb 8, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/create-file-with-comma branch February 8, 2024 10:25
saw-jan added a commit that referenced this pull request Mar 5, 2024
* test(e2e): create and download file having comma

* test: remove duplicate acceptance tests

* tag bug issue

* bump ocis commit id
saw-jan added a commit that referenced this pull request Mar 5, 2024
* test(e2e): create and download file having comma

* test: remove duplicate acceptance tests

* tag bug issue

* bump ocis commit id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants