Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] test(e2e): create and download file having comma #10447

Merged
merged 4 commits into from
Feb 8, 2024
Merged

[tests-only] test(e2e): create and download file having comma #10447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c0f72f
test(e2e): create and download file having comma
saw-jan Feb 6, 2024
590894e
test: remove duplicate acceptance tests
saw-jan Feb 6, 2024
ce62563
tag bug issue
saw-jan Feb 8, 2024
e1b2f5a
bump ocis commit id
saw-jan Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .drone.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# The version of OCIS to use in pipelines that test against OCIS
OCIS_COMMITID=5484a4a6eda1c9520e645b2119920ab76b88d1ef
OCIS_COMMITID=d87f5b031634eb60a1033fc6fb57eed732398eb5
OCIS_BRANCH=master
6 changes: 0 additions & 6 deletions tests/acceptance/features/webUICreateFilesFolders/createFile.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,3 @@ Feature: create files
When the user tries to create a file with already existing name "lorem.txt" using the webUI
Then the error message "lorem.txt already exists" should be displayed on the webUI dialog prompt
And the create file button should be disabled


Scenario: create file with name that contains commas
When the user creates a file with the name "sample,1.txt" using the webUI
And the user browses to the files page
Then file "sample,1.txt" should be listed on the webUI
7 changes: 0 additions & 7 deletions tests/acceptance/features/webUIFiles/download.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,3 @@ Feature: download files
And the user reloads the current page of the webUI
Then file "lorem.txt" should not be listed on the webUI
And as "Alice" file "lorem.txt" should not exist in the server


Scenario: download file with comma in the filename
Given user "Alice" has created file "sample,1.txt" in the server
And user "Alice" has logged in using the webUI
When the user downloads file "sample,1.txt" using the webUI
Then no message should be displayed on the webUI
7 changes: 7 additions & 0 deletions tests/e2e/cucumber/features/smoke/upload.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ Feature: Upload
| new-lorem-big.txt | txtFile | new lorem big file |
| lorem.txt | txtFile | lorem file |
| textfile.txt | txtFile | some random content |
# Coverage for bug: https://github.com/owncloud/ocis/issues/8361
| comma,.txt | txtFile | comma |
saw-jan marked this conversation as resolved.
Show resolved Hide resolved
When "Alice" uploads the following resources
| resource | option |
| new-lorem-big.txt | replace |
Expand All @@ -37,6 +39,11 @@ Feature: Upload
And "Alice" tries to upload the following resource
| resource | error |
| lorem-big.txt | Not enough quota |
And "Alice" downloads the following resources using the sidebar panel
| resource | type |
| PARENT | folder |
# Coverage for bug: https://github.com/owncloud/ocis/issues/8361
| comma,.txt | file |
# currently upload folder feature is not available in playwright
# And "Alice" uploads the following resources
# | resource |
Expand Down