Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: idp logout issues #10881

Merged
merged 1 commit into from
May 14, 2024
Merged

fix: idp logout issues #10881

merged 1 commit into from
May 14, 2024

Conversation

JammingBen
Copy link
Contributor

Description

Fixes falsely showing the logout page after opening ownCloud Web with an expired token. The issue seemed to be related to the fact that we manually logged out the user after token expiry, whereas the correct way is to let the IDP auth flow handle this. There is no need for a custom implementation on our side.

Also removes the threshold because it doesn't really make sense IMO. Either the token is expired, or it's still valid.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Fixes falsely showing the logout page after opening ownCloud Web with an expired token. The issue seemed to be related to the fact that we manually logged out the user after token expiry, whereas the correct way is to let the IDP auth flow handle this. There is no need for a custom implementation on our side.
@JammingBen JammingBen self-assigned this May 7, 2024
@JammingBen JammingBen requested review from dschmidt and kulmann May 7, 2024 08:13
@JammingBen
Copy link
Contributor Author

@kulmann @dschmidt Pinging you 2 for review since you got the most knowledge about IDP stuff. I'm still not 100% sure about the solution, but it looks good to me and seems to work.

@JammingBen JammingBen marked this pull request as ready for review May 7, 2024 08:14
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding 💪

Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (i guess)

@kulmann kulmann merged commit e373178 into stable-8.0 May 14, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/idp-logout-issues branch May 14, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants