fix: force logout after token expiry retry (backport) #11620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
commented
Sep 20, 2024
| @@ -62,7 +62,7 @@ export default defineComponent({ | |||
| } catch (e) { | |||
| console.error(e) | |||
| if (e.response?.status === 401) { | |||
| return authService.handleAuthError(unref(route)) | |||
| return authService.handleAuthError(unref(route), { forceLogout: true }) | |||
There was a problem hiding this comment.
This change here is not on master. I'm not sure if we should add it, but it might be the solution to the webfinger issues. AFAICT this now should behave like it was pre v8.0.2.
JammingBen
changed the title
JammingBen
force-pushed
the
fix/idp-logout-issues
branch
from
97b44e7 to
cdaa06b
Compare
AlexAndBear
requested changes
Sep 23, 2024
JammingBen
force-pushed
the
fix/idp-logout-issues
branch
from
cdaa06b to
bbc0045
Compare
AlexAndBear
approved these changes
Sep 23, 2024
|
kulmann
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This restores some of the behavior we had before #10881.
It is a partial backport of #11584.
Types of changes