Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable click on search button on mobile #1893

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Conversation

LukasHirt
Copy link
Collaborator

Description

Removed value from mobile search bar and reset its value after the route has been changed.

Related Issue

Motivation and Context

When the searchTerm was used as a value the button would be always disabled since the value wasn't updated when writing a new search term.

How Has This Been Tested?

  • test environment: manually
  1. Switch to mobile view in dev tools
  2. Open search bar
  3. Write a search term
  4. See button change it's colour to primary
  5. Click on the button
  6. Try navigating into found folder
  7. Open search bar again and see empty value

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer bug-solved labels Sep 3, 2019
@LukasHirt LukasHirt self-assigned this Sep 3, 2019
Reset value of search after change of route
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt merged commit 4855550 into master Sep 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/search-on-mobile branch September 5, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search button is not clickable in Mobile Phone
2 participants