Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance test to create hidden file #2153

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Acceptance test to create hidden file #2153

merged 1 commit into from
Oct 25, 2019

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Oct 4, 2019

Description

create hidden file

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@jasson99
Copy link
Contributor Author

jasson99 commented Oct 4, 2019

@dpakach ,@skshetry

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dpakach dpakach added Status:Needs-Review Needs review from a maintainer Acceptance tests labels Oct 4, 2019
individual-it
individual-it requested changes Oct 4, 2019
View reviewed changes
tests/acceptance/pageObjects/filesPage.js Outdated Show resolved Hide resolved
tests/acceptance/pageObjects/filesPage.js Outdated Show resolved Hide resolved
@PVince81
Copy link
Contributor

@jasson99 please adjust the PR title to be clearer that this is about adding tests for that feature.
The current title sounds like this PR is adding a new feature.

Thanks!

@jasson99 jasson99 changed the title create file Acceptance test to create hidden file Oct 21, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5951/

20191024-073642-565.png
20191024-073715-305.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5952/

20191024-090121-244.png
20191024-090121-314.png
20191024-090121-424.png
20191024-090121-516.png
20191024-090121-604.png
20191024-090121-689.png
20191024-090121-751.png
20191024-090147-604.png
20191024-090147-661.png
20191024-090147-771.png
20191024-090147-878.png
20191024-090147-989.png
20191024-090148-094.png
20191024-090148-182.png
20191024-090148-290.png
20191024-090148-370.png
20191024-090148-441.png
20191024-090148-517.png
20191024-090148-643.png
20191024-090148-730.png
20191024-090148-845.png
20191024-090148-929.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5967/

20191025-053103-953.png
20191025-053104-061.png
20191025-053104-185.png
20191025-053104-322.png
20191025-053104-469.png
20191025-053104-584.png
20191025-053104-705.png
20191025-053104-808.png
20191025-053105-019.png
20191025-053105-181.png
20191025-053105-339.png
20191025-053105-511.png
20191025-053105-665.png
20191025-053105-857.png
20191025-053106-000.png
20191025-053129-834.png
20191025-053129-936.png
20191025-053130-129.png
20191025-053130-295.png
20191025-053130-579.png
20191025-053130-740.png
20191025-053130-923.png
20191025-053131-104.png
20191025-053131-296.png
20191025-053131-509.png
20191025-053131-703.png
20191025-054346-076.png
20191025-054346-187.png
20191025-054346-293.png
20191025-054346-415.png
20191025-054346-568.png
20191025-054346-752.png
20191025-054346-887.png
20191025-054347-082.png
20191025-054347-245.png
20191025-054347-391.png
20191025-054347-554.png
20191025-054424-180.png
20191025-054424-375.png
20191025-054424-556.png
20191025-054424-730.png
20191025-054424-906.png
20191025-054425-085.png
20191025-054425-236.png
20191025-054425-435.png
20191025-054425-588.png
20191025-054425-820.png
20191025-054425-950.png
20191025-054426-088.png
20191025-054426-199.png
20191025-054426-307.png
20191025-054426-429.png

@DeepDiver1975 DeepDiver1975 merged commit dd459c8 into owncloud:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skshetry skshetry skshetry left review comments

@individual-it individual-it individual-it approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@dpakach dpakach Awaiting requested review from dpakach

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

Assignees

@jasson99 jasson99

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jasson99 @CLAassistant @PVince81 @ownclouders @individual-it @skshetry @DeepDiver1975 @dpakach