Acceptance test: check for the tabs displayed in details of public share page #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haribhandari07
force-pushed
the
publiclink-not-display-collaborators
branch
from
9892d34
to
dbdcbb5
Compare
haribhandari07
force-pushed
the
publiclink-not-display-collaborators
branch
2 times, most recently
from
07d4b41
to
d67bc1b
Compare
skshetry
reviewed
Nov 28, 2019
haribhandari07
force-pushed
the
publiclink-not-display-collaborators
branch
2 times, most recently
from
1f21cd9
to
f1bc7dc
Compare
skshetry
approved these changes
Nov 29, 2019
skshetry
added
Status:Needs-release
and removed
Status:Needs-Review
individual-it
requested changes
Nov 29, 2019
| const visibleTabsCollection = this.elements.tabsInSideBar.selector | ||
| const tabs = [] | ||
| let elements | ||
| await this.api.elements('xpath', visibleTabsCollection, function (result) { |
There was a problem hiding this comment.
use the location strategy of this.elements.tabsInSideBar here
haribhandari07
force-pushed
the
publiclink-not-display-collaborators
branch
from
f1bc7dc
to
849dcfe
Compare
individual-it
requested changes
Dec 2, 2019
| getVisibleTabs: async function () { | ||
| const tabs = [] | ||
| let elements | ||
| await this.api.elements('xpath', this.elements.tabsInSideBar, function (result) { |
There was a problem hiding this comment.
don't use hard-coded locator strategy here
haribhandari07
force-pushed
the
publiclink-not-display-collaborators
branch
from
849dcfe
to
ba3efc6
Compare
individual-it
requested changes
Dec 2, 2019
| getVisibleTabs: async function () { | ||
| const tabs = [] | ||
| let elements | ||
| await this.api.elements(this.elements.tabsInSideBar, function (result) { |
There was a problem hiding this comment.
Suggested change
| await this.api.elements(this.elements.tabsInSideBar, function (result) { | |
| await this.api.elements('@tabsInSideBar', function (result) { |
haribhandari07
force-pushed
the
publiclink-not-display-collaborators
branch
from
ba3efc6
to
95c57f7
Compare
individual-it
approved these changes
Dec 2, 2019
delete-merged-branch
bot
deleted the
publiclink-not-display-collaborators
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When public link share is accessed,
collaborators,linksandversionstabs are visible. This PR adds an acceptance test to verify this scenario, which is a bug as addressed in this issue: #2090Related Issue
#2090
Motivation and Context
How Has This Been Tested?
CI
Screenshots (if appropriate):
Types of changes
Checklist: