Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public link page should not display links and collaborators #2090

Closed
PVince81 opened this issue Sep 30, 2019 · 6 comments · Fixed by #6567 or #6510
Closed

Public link page should not display links and collaborators #2090

PVince81 opened this issue Sep 30, 2019 · 6 comments · Fixed by #6567 or #6510
Labels
Estimation:S(2) Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@PVince81
Copy link
Contributor

Steps

  1. Create folder "public"
  2. Create subfolder "public/sub"
  3. Share a folder "public" with link with "Editor" role
  4. Log out
  5. Open the link
  6. Open the sidebar for "sub"

Expected result

Only versions tab displayed.

Actual result

"Links" and "Collaborators" tabs are present.
Creating a public link results in a validation error "Please specify an authorization first".

We should remove those panels in public view mode !

@PVince81 PVince81 added Type:Bug Something isn't working Priority:p2-high Escalation, on top of current planning, release blocker feature:collaborators labels Sep 30, 2019
@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Sep 30, 2019
@skshetry skshetry assigned skshetry and haribhandari07 and unassigned skshetry Nov 27, 2019
@haribhandari07 haribhandari07 removed their assignment Dec 9, 2019
@pmaier1
Copy link
Contributor

pmaier1 commented Jan 8, 2020

Expected result
Only versions tab displayed.

The current oC10 public link frontend does not have the sidebar at all. I don't necessarily think that versions should be available there.

@kulmann
Copy link
Member

kulmann commented Dec 5, 2020

The right sidebar in public link contexts now only shows actions. No people, links or versions anymore.

@kulmann kulmann closed this as completed Dec 5, 2020
@saw-jan
Copy link
Member

saw-jan commented Mar 2, 2022

@kulmann this issue still persists.
And the result is different for different cases.

  1. When opened in new tab (without logout):
    hasothers

  2. When opened in private (incognito) tab: (loading doesn't finish)
    privateloading

@saw-jan
Copy link
Member

saw-jan commented Mar 3, 2022

Looks like that happened only in my machine. Sorry!

@saw-jan saw-jan closed this as completed Mar 3, 2022
@saw-jan
Copy link
Member

saw-jan commented Mar 3, 2022

But wait 😄, people, links, versions panels are still visible on the public link page when using oCIS server (oC10 is doing fine)

webUISharingPublicManagement-shareByPublicLink_feature-L90

Failed in drone: https://drone.owncloud.com/owncloud/web/23211/68/15
CC @kulmann

@saw-jan saw-jan reopened this Mar 3, 2022
@kulmann
Copy link
Member

kulmann commented Mar 10, 2022

I guess that is a regression. I'll make a PR. Thanks for bringing it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Estimation:S(2) Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
None yet
6 participants