Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide people, links, versions in public links #6567

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Hide people, links, versions in public links #6567

merged 1 commit into from
Mar 10, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Mar 10, 2022

Description

Hide people, links and versions on public links... again.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23488/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L90.png

webUISharingPublicManagement-shareByPublicLink_feature-L90.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@kulmann kulmann changed the base branch from master to refactor-publicshare-tests March 10, 2022 11:24
@kulmann kulmann merged commit 6db2647 into refactor-publicshare-tests Mar 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-panels-public-links branch March 10, 2022 11:24
@kulmann kulmann mentioned this pull request Mar 10, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public link page should not display links and collaborators
3 participants
@kulmann @ownclouders @pascalwengerter