Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Refactor publicShare tests #6510

Merged
merged 5 commits into from
Mar 10, 2022
Merged

[tests-only][full-ci] Refactor publicShare tests #6510

merged 5 commits into from
Mar 10, 2022

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Mar 2, 2022 •
edited by kulmann
Loading

Description

Changes:

  • fix access details dialog of public share and check the tabs displayed scenario steps
  • open public link shares on a new browser session
  • update expected-failure file

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label Mar 2, 2022
@saw-jan saw-jan self-assigned this Mar 2, 2022
@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23174/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@ownclouders
Copy link
Contributor

Results for oC10Basic2 https://drone.owncloud.com/owncloud/web/23174/13/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIWebdavLockProtection-move_feature-L146.png

webUIWebdavLockProtection-move_feature-L146.png

webUIWebdavLockProtection-move_feature-L147.png

webUIWebdavLockProtection-move_feature-L147.png

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23174/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:56

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23174/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@saw-jan saw-jan force-pushed the refactor-publicshare-tests branch 2 times, most recently from ac6ecd9 to 89fa564 Compare March 3, 2022 05:06
@ownclouders
Copy link
Contributor

Results for oC10Basic2 https://drone.owncloud.com/owncloud/web/23209/13/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIWebdavLockProtection-move_feature-L146.png

webUIWebdavLockProtection-move_feature-L146.png

webUIWebdavLockProtection-move_feature-L147.png

webUIWebdavLockProtection-move_feature-L147.png

@saw-jan saw-jan force-pushed the refactor-publicshare-tests branch 2 times, most recently from 8674065 to ec42d22 Compare March 3, 2022 06:01
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23211/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L90.png

webUISharingPublicManagement-shareByPublicLink_feature-L90.png

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23211/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:279

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/23211/65/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:63

@saw-jan saw-jan force-pushed the refactor-publicshare-tests branch from ec42d22 to 646fe68 Compare March 3, 2022 09:06
@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23214/61/1
The following scenarios passed on retry:

  • webUISharingInternalUsersShareWithPage/shareWithUsers.feature:91

@saw-jan saw-jan marked this pull request as ready for review March 3, 2022 10:03
@pascalwengerter
Copy link
Contributor

@saw-jan this would need a rebase but looks good so far!

@saw-jan saw-jan force-pushed the refactor-publicshare-tests branch 3 times, most recently from 6503d14 to b8ac576 Compare March 9, 2022 04:48
kiranparajuli589
kiranparajuli589 reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@saw-jan saw-jan requested a review from phil-davis March 9, 2022 05:37
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/23479/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23479/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-10-06-52-00.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23479/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-10-06-52-26.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23479/tracing/alice-shares-file-to-brian-alice-2022-3-10-06-53-47.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23479/tracing/alice-shares-file-to-brian-brian-2022-3-10-06-53-55.zip

individual-it
individual-it reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kulmann please review because this adds a new line to the expected to fail file

tests/acceptance/stepDefinitions/publicLinkContext.js Outdated Show resolved Hide resolved
@individual-it
Copy link
Member

the failure seems not to be related

@kulmann
Copy link
Member

kulmann commented Mar 10, 2022

@kulmann please review because this adds a new line to the expected to fail file

No, the fix is easy, I'll make a PR now.

@saw-jan
refactor shareViaLink test steps
f8c8bd2 
open public link on a new session

update expected failure files

fix step

add new step for public link
@saw-jan
correct grammar
cd3a4f1
@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/23501/65/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:65

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23501/71/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

individual-it
individual-it reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for #6567 to get merged, that should avoid adding more lines to the expected-to-fail file

@kulmann
Merge pull request #6567 from owncloud/fix-panels-public-links
6db2647 
Hide people, links, versions in public links
@kulmann
Copy link
Member

kulmann commented Mar 10, 2022

Merged my PR #6567 into this PR and removed the line from the expected failures file again.

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23510/67/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkCreate_feature-L190.png

webUISharingPublicBasic-publicLinkCreate_feature-L190.png

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/23510/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:77

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23517/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23517/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-10-01-37-47.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23517/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-10-01-38-09.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23517/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2022-3-10-01-38-18.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23517/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-10-01-40-21.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23517/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-10-01-40-32.zip

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23525/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:105

@kulmann kulmann merged commit da62dfd into master Mar 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the refactor-publicshare-tests branch March 10, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@individual-it individual-it individual-it left review comments

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@Talank Talank Awaiting requested review from Talank

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
6 participants
@saw-jan @ownclouders @pascalwengerter @individual-it @kulmann @kiranparajuli589