Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] run public link tests on OCIS in CI #4222

Merged
merged 2 commits into from
Oct 23, 2020
Merged

[tests-only] run public link tests on OCIS in CI #4222

merged 2 commits into from
Oct 23, 2020

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Oct 21, 2020 •
edited
Loading

Description

test public links with OCIS backend in CI

Related Issue

part of owncloud/ocis#518
fixes #4213

Motivation and Context

  1. make tests work to avoid further regressions
  2. have tests that demonstrate the current behaviour

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@individual-it individual-it self-assigned this Oct 21, 2020
@individual-it individual-it mentioned this pull request Oct 21, 2020
Closed
2 tasks
kulmann
kulmann approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@individual-it
Copy link
Member Author

There is something wrong with one test, that passes locally, but not in drone :-(

@individual-it individual-it force-pushed the publicLinkTestsOcis branch 4 times, most recently from d6f2b6d to beb319e Compare October 23, 2020 07:18
@individual-it individual-it merged commit deb4d8d into master Oct 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the publicLinkTestsOcis branch October 23, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@phil-davis phil-davis phil-davis approved these changes

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees

@individual-it individual-it

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable public link tests in CI
3 participants
@individual-it @phil-davis @kulmann