Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] run public link tests on OCIS in CI #4222

Merged
merged 2 commits into from
Oct 23, 2020
Merged

[tests-only] run public link tests on OCIS in CI #4222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
524f7fe
run public link tests on OCIS in CI
individual-it Oct 21, 2020
1db9fb2
bump ocis commit id
individual-it Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .drone.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,15 @@ config = {
'webUISharingInternalGroups',
'webUISharingNotifications'
],
'webUIOCIS6': [
'webUISharingPublic',
'webUISharingPublicDifferentRoles',
],
'webUIOCISResharing': [
# for now run this suite by itself see https://github.com/owncloud/ocis/issues/736
'webUIResharing',
]
],

},
'extraEnvironment': {
'NODE_TLS_REJECT_UNAUTHORIZED': '0',
Expand All @@ -157,7 +162,7 @@ config = {
'defaults': {
'acceptance': {
'ocisBranch': 'master',
'ocisCommit': 'af3972065926293dff5bb9f42f9ab76e7860f4ed',
'ocisCommit': '2255eed422c59c9ff7c65daf8952929607e2fffe',
},
},

Expand Down
96 changes: 92 additions & 4 deletions ...eptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@mailhog @public_link_share-feature-required @skipOnOCIS @ocis-reva-issue-64
@mailhog @public_link_share-feature-required
Feature: Share by public link with different roles
As a user
I want to share files through a publicly accessible link with different roles
Expand All @@ -11,7 +11,7 @@ Feature: Share by public link with different roles
Background:
Given user "user1" has been created with default attributes

@smokeTest
@smokeTest @skipOnOCIS @issue-ocis-reva-383
Scenario Outline: simple sharing by public link with different roles
Given user "user1" has logged in using the webUI
When the user creates a new public link for folder "simple-folder" using the webUI with
Expand All @@ -32,6 +32,29 @@ Feature: Share by public link with different roles
| Editor | read, update, create, delete |
| Contributor | read, create |


@skipOnOC10 @issue-ocis-reva-383
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario Outline: simple sharing by public link with different roles
Given user "user1" has logged in using the webUI
When the user creates a new public link for folder "simple-folder" using the webUI with
| role | <role> |
Then user "user1" should have a share with these details:
| field | value |
| share_type | public_link |
| uid_owner | user1 |
| permissions | <permissions> |
| path | /simple-folder |
And a public link with the last created link share token as name should be listed for resource "simple-folder" on the webUI
When the public uses the webUI to access the last public link created by user "user1"
Then file "lorem.txt" should be listed on the webUI
Examples:
| role | permissions |
| Viewer | read |
| Editor | read, update, create, delete |
| Contributor | read, create |

@skipOnOCIS @issue-ocis-reva-383
Scenario: sharing by public link with "Uploader" role
Given user "user1" has logged in using the webUI
When the user creates a folder with the name "shared-folder" using the webUI
Expand All @@ -48,6 +71,23 @@ Feature: Share by public link with different roles
When the public uses the webUI to access the last public link created by user "user1"
Then there should be no resources listed on the webUI

@skipOnOC10 @issue-ocis-reva-383
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario: sharing by public link with "Uploader" role
Given user "user1" has logged in using the webUI
When the user creates a folder with the name "shared-folder" using the webUI
And the user creates a new public link for folder "shared-folder" using the webUI with
| role | Uploader |
Then user "user1" should have a share with these details:
| field | value |
| share_type | public_link |
| uid_owner | user1 |
| permissions | create |
| path | /shared-folder |
And a public link with the last created link share token as name should be listed for resource "shared-folder" on the webUI
When the public uses the webUI to access the last public link created by user "user1"
Then there should be no resources listed on the webUI

Scenario: creating a public link with "Editor" role makes it possible to delete files via the link
Given user "user1" has shared folder "simple-folder" with link with "read, update, create, delete" permissions
When the public uses the webUI to access the last public link created by user "user1"
Expand All @@ -71,11 +111,19 @@ Feature: Share by public link with different roles
| zzzz-must-be-last-file-in-folder.txt |
Then the deleted elements should not be listed on the webUI

@skipOnOCIS @issue-ocis-270
Scenario: creating a public link with "Viewer" role only makes it impossible to delete files via the link
Given user "user1" has shared folder "simple-folder" with link with "read" permissions
When the public uses the webUI to access the last public link created by user "user1"
Then it should not be possible to delete file "lorem.txt" using the webUI

@skipOnOC10 @issue-ocis-270
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario: creating a public link with "Viewer" role only makes it impossible to delete files via the link
Given user "user1" has shared folder "simple-folder" with link with "read" permissions
When the public uses the webUI to access the last public link created by user "user1"
Then it should be possible to delete file "lorem.txt" using the webUI

Scenario: creating a public link with "Editor" role makes it possible to upload a file
Given user "user1" has shared folder "simple-folder" with link with "read, update, create, delete" permissions
When the public uses the webUI to access the last public link created by user "user1"
Expand Down Expand Up @@ -145,11 +193,19 @@ Feature: Share by public link with different roles
And file "child.txt" should be listed in the folder "CHILD" on the webUI
And as "user1" file "simple-folder/simple-empty-folder/PARENT/CHILD/child.txt" should exist

Scenario: creating a public link with "Viewer" role makes it possible to create files via the link even with password set
@skipOnOCIS @issue-ocis-723
Scenario: creating a public link with "Viewer" role makes it impossible to create files via the link even with password set
Given user "user1" has shared folder "simple-folder" with link with "read" permissions and password "pass123"
When the public uses the webUI to access the last public link created by user "user1" with password "pass123"
Then it should not be possible to create files using the webUI

@skipOnOC10 @issue-ocis-reva-383
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario: creating a public link with "Viewer" role makes it impossible to create files via the link even with password set
Given user "user1" has shared folder "simple-folder" with link with "read" permissions and password "pass123"
When the public uses the webUI to access the last public link created by user "user1" with password "pass123"
Then it should be possible to create files using the webUI

@issue-2414
Scenario: creating a public link with "Uploader" role makes it possible to upload a file
# FIXME: Delete this scenario after fixing the issue at large
Expand Down Expand Up @@ -185,7 +241,7 @@ Feature: Share by public link with different roles
And as "user1" the content of "simple-folder/'single'quotes.txt" should be the same as the local "'single'quotes.txt"
And as "user1" the content of "simple-folder/new-lorem.txt" should be the same as the local "new-lorem.txt"

@issue-2443 @yetToImplement
@issue-2443 @yetToImplement @skipOnOCIS
Scenario: creating a public link with "Uploader" role makes it possible to upload a folder
Given user "user1" has shared folder "simple-folder" with link with "create" permissions
When the public uses the webUI to access the last public link created by user "user1"
Expand All @@ -195,6 +251,7 @@ Feature: Share by public link with different roles
And as "user1" file "simple-folder/FOLDER" should exist
And the content of file "simple-folder/FOLDER" for user "user1" should be ""

@skipOnOCIS @issue-ocis-723
Scenario: creating a public link with "Uploader" role makes it possible to create files through files-drop page even with password set
Given user "user1" has shared folder "simple-folder" with link with "create" permissions and password "pass123"
When the public uses the webUI to access the last public link created by user "user1" with password "pass123"
Expand All @@ -203,6 +260,18 @@ Feature: Share by public link with different roles
| 'single'quotes.txt |
And as "user1" the content of "simple-folder/'single'quotes.txt" should be the same as the local "'single'quotes.txt"

@skipOnOC10 @issue-ocis-723
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario: creating a public link with "Uploader" role makes it possible to create files through files-drop page even with password set
Given user "user1" has shared folder "simple-folder" with link with "create" permissions and password "pass123"
When the public uses the webUI to access the last public link created by user "user1" with password "pass123"
And the public uploads file "'single'quotes.txt" in files-drop page
Then the following resources should be listed on the webUI
| file-name |
| 'single'quotes.txt |
And as "user1" the content of "simple-folder/'single'quotes.txt" should be the same as the local "'single'quotes.txt"

@skipOnOCIS @issue-ocis-723
Scenario: creating a public link with "Uploader" role makes it possible to upload multiple files via files-drop page even with password set
Given user "user1" has shared folder "simple-folder" with link with "create" permissions and password "pass123"
When the public uses the webUI to access the last public link created by user "user1" with password "pass123"
Expand All @@ -214,13 +283,29 @@ Feature: Share by public link with different roles
And as "user1" the content of "simple-folder/'single'quotes.txt" should be the same as the local "'single'quotes.txt"
And as "user1" the content of "simple-folder/new-lorem.txt" should be the same as the local "new-lorem.txt"

@skipOnOC10 @issue-ocis-723
#after fixing the issue delete this scenario and use the one above by deleting the @skipOnOCIS tag there
Scenario: creating a public link with "Uploader" role makes it possible to upload multiple files via files-drop page even with password set
Given user "user1" has shared folder "simple-folder" with link with "create" permissions and password "pass123"
When the public uses the webUI to access the last public link created by user "user1" with password "pass123"
And the public uploads file "'single'quotes.txt" in files-drop page
And the public uploads file "new-lorem.txt" in files-drop page
Then the following resources should be listed on the webUI
| file-name |
| 'single'quotes.txt |
| new-lorem.txt |
And as "user1" the content of "simple-folder/'single'quotes.txt" should be the same as the local "'single'quotes.txt"
And as "user1" the content of "simple-folder/new-lorem.txt" should be the same as the local "new-lorem.txt"

@skipOnOCIS @issue-ocis-reva-41
Scenario: user tries to create a public link with Viewer role without entering share password while enforce password on read only public share is enforced
Given the setting "shareapi_enforce_links_password_read_only" of app "core" has been set to "yes"
And user "user1" has logged in using the webUI
When the user creates a new public link for folder "simple-folder" using the webUI
Then the user should see an error message on the public link share dialog saying "Passwords are enforced for link shares"
And user "user1" should not have created any shares

@skipOnOCIS @issue-ocis-reva-41
Scenario: user tries to create a public link with Contributor role without entering share password while enforce password on read-write public share is enforced
Given the setting "shareapi_enforce_links_password_read_write" of app "core" has been set to "yes"
And user "user1" has logged in using the webUI
Expand All @@ -229,6 +314,7 @@ Feature: Share by public link with different roles
Then the user should see an error message on the public link share dialog saying "Passwords are enforced for link shares"
And user "user1" should not have created any shares

@skipOnOCIS @issue-ocis-reva-41
Scenario: user tries to create a public link with Editor Role without entering share password while enforce password on read-write public share is enforced
Given the setting "shareapi_enforce_links_password_read_write_delete" of app "core" has been set to "yes"
And user "user1" has logged in using the webUI
Expand All @@ -237,6 +323,7 @@ Feature: Share by public link with different roles
Then the user should see an error message on the public link share dialog saying "Passwords are enforced for link shares"
And user "user1" should not have created any shares

@skipOnOCIS @issue-ocis-reva-41
Scenario: user tries to create a public link with Uploader role without entering share password while enforce password on write only public share is enforced
Given the setting "shareapi_enforce_links_password_write_only" of app "core" has been set to "yes"
And user "user1" has logged in using the webUI
Expand All @@ -245,6 +332,7 @@ Feature: Share by public link with different roles
Then the user should see an error message on the public link share dialog saying "Passwords are enforced for link shares"
And user "user1" should not have created any shares

@skipOnOCIS @issue-ocis-reva-41
Scenario: user creates a public link with Contributor Role without entering share password while enforce password on read only public share is enforced
Given the setting "shareapi_enforce_links_password_read_only" of app "core" has been set to "yes"
And user "user1" has logged in using the webUI
Expand Down
25 changes: 21 additions & 4 deletions tests/acceptance/stepDefinitions/filesContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,14 +936,31 @@ When('the user deletes the file {string} from the deleted files list', function(
return client.page.FilesPageElement.filesList().deleteImmediately(element)
})

async function isPossibleToDeleteResourceOnWebUI(resource) {
return !(await client.page.FilesPageElement.filesList().isActionAttributeDisabled(
'delete',
resource
))
}

Then('it should not be possible to delete file/folder {string} using the webUI', async function(
resource
) {
const state = await client.page.FilesPageElement.filesList().isActionAttributeDisabled(
'delete',
resource
assert.strictEqual(
await isPossibleToDeleteResourceOnWebUI(resource),
false,
`expected delete function of ${resource} to be disabled but it is enabled`
)
})

Then('it should be possible to delete file/folder {string} using the webUI', async function(
resource
) {
assert.strictEqual(
await isPossibleToDeleteResourceOnWebUI(resource),
true,
`expected delete function of ${resource} to be enabled but it is disabled`
)
assert.ok(state, `expected property disabled of ${resource} to be 'true' but found ${state}`)
})

Then('it should not be possible to rename file/folder {string} using the webUI', async function(
Expand Down