Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trash bin enhancements #6609

Merged
merged 14 commits into from
Mar 21, 2022
Merged

Trash bin enhancements #6609

merged 14 commits into from
Mar 21, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 17, 2022 •
edited
Loading

Description

  • Add a breadcrumb for personal trash bin
  • Improve the breadcrumb for spaces trash bin, also add 'Navigate to space' action to context menu
  • Fix wrong page title in spaces trash bin

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

  • Page title rendered correctly in space trash bin
    image

  • Navigate to space action in app bar
    image

  • Breadcrumb for personal trash bin
    image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Mar 17, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23790/67/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23790/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:105

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23809/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23809/61/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:136

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/23823/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:216

@ownclouders
Copy link
Contributor

ownclouders commented Mar 18, 2022 •
edited
Loading

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23913/71/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks_feature-L17.png

webUIPrivateLinks-accessingPrivateLinks_feature-L17.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear changed the title Fix single space page title, add trash space title Trash bin enhancements Mar 18, 2022
@AlexAndBear AlexAndBear marked this pull request as ready for review March 18, 2022 13:58
@AlexAndBear AlexAndBear requested review from kulmann, pascalwengerter, fschade and JammingBen and removed request for pascalwengerter and fschade March 18, 2022 13:58
pascalwengerter
pascalwengerter approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

packages/web-app-files/tests/unit/components/AppBar/AppBar.spec.js Outdated Show resolved Hide resolved
packages/web-app-files/tests/unit/components/AppBar/AppBar.spec.js Outdated Show resolved Hide resolved
packages/web-app-files/tests/unit/components/AppBar/AppBar.spec.js Outdated Show resolved Hide resolved
packages/web-app-files/src/mixins/actions/restore.js
@@ -26,6 +26,10 @@ export default {
) {
return false
}
if (!resources.every((r) => r.canBeRestored())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use this logic more often. I think currently the user is being offered to perform certain batch actions that then fail somewhere down the selected items because permissions are missing 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that special case, the permission check will be done via WebDavProperties, but not implemented yet in the backend

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

67.1% 67.1% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit a2dd03a into master Mar 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the space-trashbin-enhancements branch March 21, 2022 11:09
@pascalwengerter pascalwengerter mentioned this pull request Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@fschade fschade Awaiting requested review from fschade

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @ownclouders @pascalwengerter