Move isIE check to deprecation warning banner #6629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
force-pushed
the
move-is-ie-check-to-banner
branch
from
087b639
to
16ac77e
Compare
|
|
pascalwengerter
force-pushed
the
move-is-ie-check-to-banner
branch
from
16ac77e
to
aa7a582
Compare
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Mar 21, 2022
JammingBen
approved these changes
Mar 21, 2022
| isIE11() { | ||
| return !!window.MSInputMethodContext && !!document.documentMode | ||
| }, | ||
| IEdeprecationWarning() { |
There was a problem hiding this comment.
Is this correct camel case? 🤔 Thinking of ieDeprecationWarning or IEDeprecationWarning
There was a problem hiding this comment.
true, ieDeprectationWarning would be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Could use feedback on wording and needs #6609 merged first