Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shares breadcrumb #6965

Merged
merged 3 commits into from
May 13, 2022
Merged

Add shares breadcrumb #6965

merged 3 commits into from
May 13, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented May 13, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented May 13, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

pascalwengerter
pascalwengerter approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/25561/56/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIDeleteFilesFolders-deleteFilesFolders_feature-L244.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L244.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

pascalwengerter
pascalwengerter reviewed May 13, 2022
View reviewed changes
packages/web-app-files/src/views/shares/SharedResource.vue
@@ -169,6 +169,10 @@ export default defineComponent({

breadcrumbs() {
return concatBreadcrumbs(
{
text: this.$gettext('Shares'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait no, this can only happen if sharing jail is there (oCIS feature)!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will add a check later, just sitting on other stuff right now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check not needed. The view only gets navigated to in ocis with sharin jail. Oc10 navigates into mounted share in "All files" view.

@sonarcloud
Copy link

sonarcloud bot commented May 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit e8e94b7 into master May 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/6937 branch May 13, 2022 09:54
@kulmann kulmann mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann kulmann left review comments

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Shares breadcrumb root when navigating into a share
4 participants
@AlexAndBear @ownclouders @kulmann @pascalwengerter