Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shares breadcrumb #6965

Merged
merged 3 commits into from
May 13, 2022
Merged

Add shares breadcrumb #6965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d26a45
Add shares breadcrumb
May 13, 2022
bcc6dff
Add changelog item
May 13, 2022
1f72d0e
Update changelog item
May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/unreleased/bugfix-add-root-breadcrumb-to-shared-with-me-page
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Bugfix: We added the shares item to the breadcrumbs at the shared with me page

https://github.com/owncloud/web/pull/6965
https://github.com/owncloud/web/issues/6937
4 changes: 4 additions & 0 deletions packages/web-app-files/src/views/shares/SharedResource.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ export default defineComponent({

breadcrumbs() {
return concatBreadcrumbs(
{
text: this.$gettext('Shares'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait no, this can only happen if sharing jail is there (oCIS feature)!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will add a check later, just sitting on other stuff right now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check not needed. The view only gets navigated to in ocis with sharin jail. Oc10 navigates into mounted share in "All files" view.

to: { path: '/files/shares' }
},
{
text: this.$gettext('Shared with me'),
to: { path: '/files/shares/with-me' }
Expand Down