Don't show user management in app switcher if user has not role 'admin' #7197
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/26523/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/26523/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-6-29-12-28-25.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/26523/tracing/file-alice-2022-6-29-12-27-16.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/26523/tracing/folder-alice-2022-6-29-12-26-08.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/26523/tracing/public-link-alice-2022-6-29-12-25-00.zip |
| store: Store<any> | ||
| }): void => { | ||
| const permissionManager = new PermissionManager(store) | ||
| vue.prototype.$permissionManager = permissionManager |
There was a problem hiding this comment.
You don't need to do both. Either set it on prototype or use reactive set. They both have the same result, so one is sufficient.
There was a problem hiding this comment.
I tried that.
If I only use set(vue, '$permissionManager', permissionManager), the permissionManager is accessible in /home/jan/working/web/packages/web-app-user-management/src/index.js but not in
/home/jan/working/web/packages/web-app-files/src/views/spaces/Projects.vue
and vice versa, I have no clue why this is the case :x
|
SonarCloud Quality Gate failed. |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: