oc10: Shareindicator for incoming shares in "All files" is misleading #7686

gitstart · 2022-09-23T14:49:37Z

Description

Changed the shareindicator text from "show invited people" to "Shared with you, show details"

Related Issue

Fixes #7625

Screenshots (if appropriate):

https://www.loom.com/share/a4f4be23ef9748399730af15a5963db7

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

This PR was pushed through GitStart, with contributions from @NickM101 @faridomarafg @WajihaNiazi, @hashimaziz46

JammingBen

Thanks for your contribution! I'm afraid it's not that simple though.

First we need to make sure that this only applies to oC10. This can be done easily by checking hasShareJail === true here.

Then we need to make sure that this only takes effect if this file has no outgoing shares. The sharesTree provides this kind of information.

Last but not least, we want the share indicator to redirect to the "Shared with me"-page if the above two conditions are true. Ideally including the scrollTo param to directly scroll to the resource.

gitstart · 2022-09-28T12:33:54Z

Thanks for your contribution! I'm afraid it's not that simple though.

First we need to make sure that this only applies to oC10. This can be done easily by checking hasShareJail === true here.

Then we need to make sure that this only takes effect if this file has no outgoing shares. The sharesTree provides this kind of information.

Last but not least, we want the share indicator to redirect to the "Shared with me"-page if the above two conditions are true. Ideally including the scrollTo param to directly scroll to the resource.

Thank you for your nice feedback we will resolve ASAP