[full-ci] Improve performance when loading folders and share indicators

[JammingBen]

Description

• When adding/removing shares, we update the sharesTree manually instead of re-loading it completely
• When loading share indicators, we rely on the shareType property on the resource (for direct shares) and on the parent folders (for indirect shares).
• The sharesTree is now only loaded when accessing the sidebar (before, it was loaded as soon as you navigated into a folder, as well as on resource creation).

Related Issue

• Fixes Speed up building share indicators #7721
• Fixes oc10: Shareindicator for incoming shares in "All files" is misleading #7625
• Fixes Indirect shares can't be loaded for nested folders in spaces #7655

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

To-Dos

• Fix depth: 0
• Fix getParentFolders() usage in FileDetails
• Remove !!this.currentFolder?.shareTypes?.length check in CreateAndUpload.vue
• Only fetch shareType and path when listing all parent folders
• Move re-usable parts into composable
• Properly load parent folders (where?)
• Testing

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ownclouders]

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/32517/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32517/tracing/participant-management-alice-2023-2-7-12-02-29.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32517/tracing/participant-management-anonymous-2023-2-7-12-03-02.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32517/tracing/participant-management-brian-2023-2-7-12-02-38.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32517/tracing/participant-management-carol-2023-2-7-12-02-51.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32517/tracing/participant-management-marie-2023-2-7-12-02-42.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/32517/tracing/participant-management-richard-2023-2-7-12-02-46.zip

[ownclouders]

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/32508/31/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroupsSharingIndicator-shareWithGroups_feature-L65.png

webUISharingInternalGroupsSharingIndicator-shareWithGroups_feature-L86.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups_feature-L58.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups_feature-L74.png

webUISharingInternalUsersSharingIndicator-shareWithUsers_feature-L104.png

webUISharingInternalUsersSharingIndicator-shareWithUsers_feature-L127.png

webUISharingInternalUsersToRootSharingIndicator-shareWithUsers_feature-L52.png

webUISharingInternalUsersToRootSharingIndicator-shareWithUsers_feature-L69.png

[JammingBen]

Status: The indicator loading when adding or removing shares still has some fllaws. We also need the parent folders here, so that needs to be implemented properly first. Where do we want to load the parent folders? How do we persist them?

Edit: See #8383

[kulmann]

❤️

[kulmann]

The callback args newResource and oldResource are not a list of resources anymore, because you added an additional attribute in the watcher. They are now arrays of resources and an additional boolean. That breaks the check in line 275 on !!oldResource.

[JammingBen]

Good catch, thx! I removed it completely, as we don't need it anymore. There is still room for some improvements when navigating with an opened sidebar, but it's already 100 times better than before.

[kulmann]

cc @pascalwengerter @diocas @elizavetaRa this PR removes the ugly loading of shares via ocs in the file list (for the share indicators) and switches to super slim propfinds on parent folders. I think this should be pretty noticeable in cernbox. @JammingBen also tried to make the ancestor propfinds non-blocking (and re-rendering the rows that have a share indicator), but that was not very promising even with Vue3. If you want to try that for cernbox I'd love to hear about your experience.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

52.5% Coverage
2.1% Duplication

[kulmann]

❤️