Fix missing password form on public drop page #8007
Conversation
JammingBen
changed the title
JammingBen
force-pushed
the
fix-missing-public-password-form
branch
from
1d3f873 to
fddde38
Compare
It seems |
| @@ -151,7 +152,7 @@ export default defineComponent({ | |||
| .catch((error) => { | |||
| // likely missing password, redirect to public link password prompt | |||
| if (error.statusCode === 401) { | |||
| return this.$authService.handleAuthError(this.$router.currentRoute) | |||
There was a problem hiding this comment.
Is the authService not available anymore as this.$authService? 🤔
There was a problem hiding this comment.
See #8007 (comment). I'm down to undo the change and rather fix it in announceAuthService, but I'm not sure why it's not working...?
There was a problem hiding this comment.
Working with prototype seems to be the right way though: https://v2.vuejs.org/v2/cookbook/adding-instance-properties.html. I'll add it.
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -322,6 +322,7 @@ export const announceAuthService = ({ | |||
| router: VueRouter | |||
| }): void => { | |||
| authService.initialize(configurationManager, clientService, store, router) | |||
| vue.prototype.$authService = authService | |||
| set(vue, '$authService', authService) | |||
There was a problem hiding this comment.
I guess you can remove this line then.
There was a problem hiding this comment.
Thought so too, but it gives me: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'initializeContext') 🤔 It's the same for $permissionManager.
There was a problem hiding this comment.
delete-merged-branch
bot
deleted the
fix-missing-public-password-form
branch
Description
We've fixed a bug where the password form on a public drop page would not show after setting a required password.
Related Issue
Types of changes