Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing password form on public drop page #8007

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Fix missing password form on public drop page #8007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fddde38
Fix missing password form on public drop page
JammingBen Nov 21, 2022
568229c
Fix issue with providing the authService globally
JammingBen Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-missing-public-password-form
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Missing password form on public drop page

We've fixed a bug where the password form on a public drop page would not show after setting a required password.

https://github.com/owncloud/web/pull/8007
https://github.com/owncloud/web/issues/7670
1 change: 1 addition & 0 deletions packages/web-runtime/src/container/bootstrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ export const announceAuthService = ({
router: VueRouter
}): void => {
authService.initialize(configurationManager, clientService, store, router)
vue.prototype.$authService = authService
set(vue, '$authService', authService)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can remove this line then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought so too, but it gives me: Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'initializeContext') 🤔 It's the same for $permissionManager.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this here: https://github.com/owncloud/web/blob/fix-missing-public-password-form/packages/web-runtime/src/router/setupAuthGuard.ts#L14

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a mess. You're a hero!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urgh... awesome 🤗

}

Expand Down