[full-ci] Enhancement: Add whitespace context-menu

[lookacat]

Description

We've added a generic context-menu for right clicking on whitespace.
See #5861

Related Issue

• Fixes Open Context menu on click on whitespace #5861

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• [full-ci] Refactor CreateAndUpload into composables #8938

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[lookacat]

Refactoring of the CreateAndUpload component into composables needed before this PR
#8938

[tbsbdr]

cool one 👍

• current clickable locations to get the menu is good imo ✅
• A remark on Icon+wording: I'd suggest du directly show the folder icon (instead of the "+") and just call it "New Folder" (create new is semantically redundant)

[lookacat]

@kulmann to the first point yes i can do that, the second point: Did you try it in the space root? in subfolders it should work, my assumption was there is no detail on the e.g. personal space root? Or did i miss something?

[kulmann]

@kulmann to the first point yes i can do that, the second point: Did you try it in the space root? in subfolders it should work, my assumption was there is no detail on the e.g. personal space root? Or did i miss something?

ah. uh. I think both of my findings were bogus...

• "Show Details" from whitespace context menu correctly clears the selection
• "Show Details" from whitespace context menu correctly shows details...

For the personal space root it's a little bit confusing because the personal space doesn't have details. So that could be a tiny improvement: don't show the Show Details action in the whitespace context menu of the personal space root.

[lookacat]

@kulmann alright shouldl be doable, the first point was right, i just fixed it ^^

[kulmann]

Why did you decide to not use the ContextActionMenu.vue component? 🤔

[lookacat]

Actually you are right, was reverse engineering the context menu in order to understand it but didn't notice that I now can use the same component, wasn't clear if i would be able to use it at first

[lookacat]

but will try to use it, shouldn't be much difference between those two besides the sections

[lookacat]

arg, my assumption was wrong, can't get the ContextActionMenu to work at this point because _tippy is always undefined, would rename it to WhitespaceContextMenu for now :/

[lookacat]

don't see how to quickly fix that, also there are some differences between those two component

[kulmann]

Found two more things. Also, what about unit tests, at least for opening the whitespace context menu (not for the actions inside it)?

[lookacat]

@kulmann done

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
11 Code Smells

46.9% Coverage
0.0% Duplication

[kulmann]

Awesome stuff! Love the UX of this 😍