[full-ci] Refactor CreateAndUpload into composables #8938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
10 tasks
lookacat
commented
Apr 27, 2023
packages/web-app-files/src/components/FilesList/ContextActions.vue
Outdated
Show resolved
Hide resolved
lookacat
changed the title
JammingBen
reviewed
Apr 27, 2023
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
requested changes
Apr 28, 2023
packages/web-app-files/src/composables/actions/files/useFileActionsCreateNewFile.ts
Outdated
Show resolved
Hide resolved
JammingBen
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Few smaller things from my side, looks quite good overall.
Types need to be improved, but that can be done in a follow-up IMO because they should be added and used globally (talking about newFileHandlers and mimetypesAllowedForCreation).
Also, we definitely need to test this with a WOPI instance before merging.
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
| const openAction = newFileHandler.action | ||
| actions.push({ | ||
| name: 'create-new-file', | ||
| icon: 'add', |
There was a problem hiding this comment.
Idea for the future: In CreateAndUpload we currently load the icon via getIconResource. Would be nice to somehow handle this here. Maybe we can even remove ext: newFileHandler.ext then (which is only used for the icon).
packages/web-app-files/src/composables/actions/files/useFileActionsCreateNewFile.ts
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/composables/actions/files/useFileActionsCreateNewFolder.ts
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/composables/actions/files/useFileActionsCreateNewFile.ts
Outdated
Show resolved
Hide resolved
lookacat
force-pushed
the
refactor-create-and-upload-composables
branch
from
906b21a
to
2a3ae5b
Compare
|
Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35378/14/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUICreateFilesFolders-createFile_feature-L13.pngwebUICreateFilesFolders-createFile_feature-L25.pngwebUICreateFilesFolders-createFile_feature-L31.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L19.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L20.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L21.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L22.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L23.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L24.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L25.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L26.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L43.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L44.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L60.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L61.pngwebUICreateFilesFolders-createFolderEdgeCases_feature-L62.pngwebUICreateFilesFolders-createFolders_feature-L12.pngwebUICreateFilesFolders-createFolders_feature-L22.pngwebUICreateFilesFolders-createFolders_feature-L53.pngwebUICreateFilesFolders-createFolders_feature-L61.pngwebUICreateFilesFolders-createFolders_feature-L74.pngwebUIDeleteFilesFolders-deleteFilesFolders_feature-L114.png |
lookacat
changed the title
lookacat
force-pushed
the
refactor-create-and-upload-composables
branch
from
2a3ae5b
to
8bfdfe3
Compare
|
Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35378/54/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUICreateFilesFolders-createFolders_feature-L61.png |
lookacat
force-pushed
the
refactor-create-and-upload-composables
branch
from
0582c66
to
3de5db8
Compare
JammingBen
reviewed
May 3, 2023
packages/web-app-files/src/components/SideBar/Shares/Links/CreateQuickLink.vue
Outdated
Show resolved
Hide resolved
JammingBen
approved these changes
May 3, 2023
There was a problem hiding this comment.
Nice one! Potential follow-ups for the future:
- Improve types (especially
newFileHandlersandmimetypesAllowedForCreation) - Make use of the
iconproperty on theactionscomputed (see [full-ci] Refactor CreateAndUpload into composables #8938 (comment)) - Maybe try to reduce code duplication a bit more. The methods for checking the name e.g. are almost identical
|
Kudos, SonarCloud Quality Gate passed! |
AlexAndBear
approved these changes
May 3, 2023
delete-merged-branch
bot
deleted the
refactor-create-and-upload-composables
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor CreateAndUpload actions into composables
Related Issue
Motivation and Context
In order to use "create new file" (type: xyz) or "create new folder" on multiple places we refactored them into composables
As needed in the linked whitespace contextmenu
Types of changes
Checklist:
Open tasks: