Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Refactor CreateAndUpload into composables #8938
[full-ci] Refactor CreateAndUpload into composables #8938
Changes from 25 commits
6787465
667e727
2a685cd
a98ff9a
f41a535
4bc18e4
69423d3
55b9d7d
07d5bf7
a7282a3
74f4174
e375562
ad4b4bb
cdfe227
cf78597
fa0a8cf
c92da28
8bfdfe3
100a8cb
5791cef
3de5db8
0945b4f
b9d4b14
08c264f
8d4e6e5
18a7a4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea for the future: In
CreateAndUpload
we currently load the icon viagetIconResource
. Would be nice to somehow handle this here. Maybe we can even removeext: newFileHandler.ext
then (which is only used for the icon).