[full-ci] Use provide/inject for service injection #9222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
force-pushed
the
use-provide-inject-for-services
branch
from
196f496 to
ae7550a
Compare
dschmidt
commented
Jun 13, 2023
packages/web-runtime/src/index.ts
Outdated
| app.use(abilitiesPlugin, createMongoAbility([]), { useGlobalProperties: true }) | ||
|
|
||
| // TODO: move to announceArchiverService function |
There was a problem hiding this comment.
I will be juggling around quite a bit with init order, so I would like to tackle this in a follow up
|
Results for e2e-tests oCIS-2 https://drone.owncloud.com/owncloud/web/36517/13/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36517/tracing/download-space-alice-2023-6-13-10-52-42.zip |
dschmidt
changed the title
dschmidt
force-pushed
the
use-provide-inject-for-services
branch
2 times, most recently
from
0b97b8f to
722a270
Compare
|
Results for e2e-tests oCIS-1 https://drone.owncloud.com/owncloud/web/36517/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36517/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-6-13-10-51-16.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36517/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-6-13-10-51-41.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36517/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-6-13-10-51-46.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36517/tracing/public-link-alice-2023-6-13-10-54-18.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36517/tracing/public-link-anonymous-2023-6-13-10-54-36.zip |
dschmidt
force-pushed
the
use-provide-inject-for-services
branch
from
722a270 to
807ebb6
Compare
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/36518/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36518/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2023-6-13-11-59-26.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36518/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2023-6-13-11-59-45.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36518/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-carol-2023-6-13-11-59-51.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36518/tracing/public-link-alice-2023-6-14-12-01-49.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/36518/tracing/public-link-anonymous-2023-6-14-12-02-11.zip |
dschmidt
force-pushed
the
use-provide-inject-for-services
branch
from
807ebb6 to
445b06f
Compare
dschmidt
commented
Jun 14, 2023
| @@ -59,12 +59,13 @@ function getMountedWrapper({ mocks = {}, files = [], loading = false } = {}) { | |||
| const storeOptions = { ...defaultStoreMockOptions } | |||
| const store = createStore(storeOptions) | |||
| return { | |||
| mocks: defaultMocks, | |||
| provide: defaultMocks, | |||
lookacat
reviewed
Jun 14, 2023
kulmann
reviewed
Jun 14, 2023
10 tasks
|
Kudos, SonarCloud Quality Gate passed! |
kulmann
approved these changes
Jun 15, 2023
| @@ -74,6 +79,24 @@ export const bootstrapApp = async (configurationPath: string): Promise<void> => | |||
| translations: merge(translations, customTranslations) | |||
| }) | |||
| announceClientService({ app, runtimeConfiguration, configurationManager, store }) | |||
|
|
|||
| // TODO: move to announceArchiverService function | |||
There was a problem hiding this comment.
can you resolve this todo in this PR or as an immediate followup please?
There was a problem hiding this comment.
ah, your comment about followup was not visible in my review anymore (probably because of history change). fine by me if you do that in a followup. but it's easily forgotten and not a hard task, so please better earlier than later ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use inject/provide for service injection instead of relying on the deprecated/discouraged
getCurrentInstanceRelated Issue
Motivation and Context
We want to enable extensions to use composables, for that we need to get rid of getCurrentInstance which is discouraged and not supported in that context.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: