Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Get rid of getCurrentInstance #9232

Merged
merged 1 commit into from
Jun 19, 2023
Merged

[full-ci] Get rid of getCurrentInstance #9232

merged 1 commit into from
Jun 19, 2023

Conversation

dschmidt
Copy link
Member

Description

This PR replaces usages of getCurrentInstance with proper apis.

Related Issue

Motivation and Context

getCurrentInstance is discouraged.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jun 14, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dschmidt dschmidt changed the title Get rid of getCurrentInstance [full-ci] Get rid of getCurrentInstance Jun 14, 2023
@dschmidt dschmidt force-pushed the replace-get-current-instance branch from b85f8f1 to ae2232f Compare June 14, 2023 20:11
@dschmidt
Remove getCurrentInstance usage
c0d56f0 
... as it's discouraged and we don't need it
@dschmidt dschmidt force-pushed the replace-get-current-instance branch from ae2232f to c0d56f0 Compare June 15, 2023 10:24
@dschmidt dschmidt marked this pull request as ready for review June 15, 2023 10:24
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

72.9% 72.9% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 16a84e3 into master Jun 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the replace-get-current-instance branch June 19, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschmidt @kulmann