removed margin to fix center position + overflow on mobile #9351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimmoc
changed the title
JammingBen
approved these changes
Jul 6, 2023
| @@ -0,0 +1,6 @@ | |||
| Bugfix: Media controls overflow on mobile screens | |||
|
|
|||
| Media controls overflowed on smaller 9:16 screens because it is absolutely positioned and centered using transform property, its margin caused the transform operation to not calculate the center properly (the latter also affected desktop but was merely visible). | |||
There was a problem hiding this comment.
This is nice technical detail which is great to have as PR description (like you do). For a changelog item however it's a bit much technical detail as those items are usually intended for end users.
An exception are changes that target developers, e.g. changes in the extension framework.
grimmoc
force-pushed
the
9318-fix-media-controls-overflow
branch
from
92fe315 to
fbcf402
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Media controls overflowed on smaller 9:16 screens because it is absolutely positioned and centered using transform property, its margin caused the transform operation to not calculate the center properly (the latter also affected desktop but was merely visible).
Related Issue
Types of changes
Checklist:
Open tasks: