Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed margin to fix center position + overflow on mobile #9351

Merged
merged 2 commits into from
Jul 12, 2023
Merged

removed margin to fix center position + overflow on mobile #9351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44cd2a5
removed margin to fix center po
grimmoc Jul 5, 2023
fbcf402
added PR number
grimmoc Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-media-controls-overflow
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Media controls overflow on mobile screens

Media controls overflowed on smaller 9:16 screens because it is absolutely positioned and centered using transform property, its margin caused the transform operation to not calculate the center properly (the latter also affected desktop but was merely visible).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice technical detail which is great to have as PR description (like you do). For a changelog item however it's a bit much technical detail as those items are usually intended for end users.

An exception are changes that target developers, e.g. changes in the extension framework.


https://github.com/owncloud/web/pull/9351
https://github.com/owncloud/web/issues/9318
2 changes: 1 addition & 1 deletion packages/design-system/src/styles/theme/oc-position.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
}

.oc-position-medium {
margin: 30px;
margin: 30px 0;
max-width: calc(100% - 60px);
}

Expand Down