Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared with action menu expiration date label alignment #9529

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

koebel
Copy link
Contributor

@koebel koebel commented Aug 2, 2023

Description

Previously in the label of the option "set expiration date" and “edit expiration date” for resources in the Shares sidebar was not in line. The same problem also applied to expiration date of members in Spaces. I removed the spacing between the icons and labels of the options below “set/edit expiration date” so that the design matches with the spacing of the same feature for sharing links.

Related Issue

Motivation and Context

Maintain consistent design in the UI

How Has This Been Tested?

inspecting HTML code output, manual testing in Chrome

Screenshots (if appropriate):

Design Reference for width of spacing
Screenshot_Shares_Add_Expiration_Date_Design_Reference

Shares after modification
Screenshot_Shares_Set_Expiration_Date_after_modification

Spaces after modification
Screenshot_Spaces_Set_Expiration_Date_after_modification

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • [x ] Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@koebel koebel added Status:Needs-Review Needs review from a maintainer Topic:UX-Design Category:Change Change existing functionality labels Aug 2, 2023
@koebel koebel requested a review from AlexAndBear August 2, 2023 14:05
@koebel koebel self-assigned this Aug 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit fd9f7bc into master Aug 2, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the shared-with-action-align-label-new branch August 2, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Change Change existing functionality Status:Needs-Review Needs review from a maintainer Topic:UX-Design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alignment of expiration date for shares
2 participants