Shared with action menu label alignment #9324

koebel · 2023-06-30T10:07:00Z

Description

Previously in the label of the option "set expiration date" and “edit expiration date” for resources in the Shares sidebar was not in line. The same problem also applied to expiration date of members in Spaces. I removed the spacing between the icons and labels of the options below “set/edit expiration date” so that the design matches with the spacing of the same feature for sharing links.

Related Issue

Fixes alignment of expiration date for shares #9323

Motivation and Context

Maintain consistent design in the UI

How Has This Been Tested?

inspecting HTML code output, manual testing in Chrome

Screenshots (if appropriate):

Design Reference for width of spacing

Shares after modification

Spaces after modification

Types of changes

[x ] Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

[x ] Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

...

* make proper use of waitForResponse * refactor * check file after copy,move action

#9254) I've money-patched that for the release of tag v7.0.2 during the sign process. Co-authored-by: Juergen Weigert <jnweiger@gmail.com>

…623-stable [tests-only][full-ci]Bump commit id for tests

* Load common theme into store * Implement url in access denied page * Fix add return * Add changelog * Update/add unittests * Update config.spec.ts * Fix typo * Rename accessDeniedHelpUrl * Fix acceptance tests, remove dev leftover * Rename more to readmore

Fixes uploading resources to folders that contain special characters in their names. This also includes fixes for name conflict handling when running oC10 as server.

Some a11y fixes

…3c-stable [tests-only][full-ci] Bump ocis commit id for tests

sonarcloud · 2023-06-30T10:15:11Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

…30630 Merge stable 7.0 to master

changelog/unreleased/bugfix-label-alignment

…ource is deleted or disabled (space) (#9502) * Show error message while accessing a public link which originated resource is deleted or disabled (space) * Rm new line

* bump latest ocis commit (#9476) * [tx] updated from transifex * chore: prepare release v7.1.0-rc.2 * chore: move changelog items back to unreleased * fix: respect supportedClouds config * test: add unit tests for cloud import action handler * Initialize Drop Target after load time * fix: logo not showing * chore: prepare release v7.1.0-rc.3 * chore: move changelog items back to unreleased * feat: add tx config for importer app * feat: add missing cloud importer translations * chore: bump owncloud uppy --------- Co-authored-by: Karun Atreya <33852651+KarunAtreya@users.noreply.github.com> Co-authored-by: ownClouders <devops@owncloud.com> Co-authored-by: Phil Davis <phil@jankaritech.com> Co-authored-by: Jacob Noah <jacob.noah.jnn@gmail.com>

chore: TypeScript 5

* Use new spaces endpoint for search * Bump sdk and ocis commit id * Add spaces check

…type fix: ApplicationTranslations type

JammingBen · 2023-08-02T06:08:56Z

@koebel Do you still plan to rebase, or should we take care?

Co-authored-by: Phil Davis <phil@jankaritech.com>

…hub.com/owncloud/web into shared-with-action-menu-label-alignment

koebel · 2023-08-02T08:57:40Z

@JammingBen thanks for the reminder. I just rebased. Locally all tests passed, so I expect that CI will pass in a little moment :)

JammingBen · 2023-08-02T10:56:50Z

Hmm something is still off, the pipeline doesn't get past the first steps. Are you sure you rebased with current master? 😅 Not sure about the merge commit (4433ced), simply git rebase origin/master should do the trick.

Co-authored-by: Phil Davis <phil@jankaritech.com>

…hub.com/owncloud/web into shared-with-action-menu-label-alignment

JammingBen · 2023-08-02T11:17:44Z

Now there is something off completely, it shows 200+ commits 🙈 Don't know what happened here, probably the easiest way is to reset it:

git reset --hard origin/master
git cherry-pick 54bdd385bd7b4d19bb081e83e51caacc7e2fd165
git cherry-pick 5aa2d1bb106db1d1e68ebcb257bc1fc808b91462

Co-authored-by: Phil Davis <phil@jankaritech.com>

…hub.com/owncloud/web into shared-with-action-menu-label-alignment

sonarcloud · 2023-08-02T11:36:01Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

koebel · 2023-08-02T12:13:04Z

Now there is something off completely, it shows 200+ commits 🙈 Don't know what happened here, probably the easiest way is to reset it:
git reset --hard origin/master
git cherry-pick 54bdd385bd7b4d19bb081e83e51caacc7e2fd165
git cherry-pick 5aa2d1bb106db1d1e68ebcb257bc1fc808b91462

thanks, it seems like it worked now

JammingBen · 2023-08-02T12:20:56Z

There is still something wrong:

It also still shows your merge commit which shouldn't be there anymore. Are you sure you ran the git commands correctly?

koebel · 2023-08-02T13:43:39Z

There is still something wrong:
It also still shows [your merge commit](https://github.com//pull/9324/commits/06ccbeb2b4b04a446f1bd1e87bf5c9df01f32d74) which shouldn't be there anymore. Are you sure you ran the git commands correctly?

@JammingBen Thanks for your feedback, I don't know what exactly went wrong. There must have been a problem with the rebasing at some point because it shows all (or at least some) of the commits made by others since I created this PR several weeks ago upto now. My suggestion is to close this thread without merging and replicate the minor code changes in a new branch and create a new PR. I assume this takes less time than trying to reverse engineer what went wrong. Is this approach ok?

koebel · 2023-08-02T14:05:52Z

this PR is replaced by #9529

saw-jan and others added 20 commits June 16, 2023 11:13

[tests-only] Make proper use of Promise.all (#9116)

e15a5d3

* make proper use of waitForResponse * refactor * check file after copy,move action

Bump ocis commit id for tests (#9253)

078e6e4

bump info.xml to 7.0.2 -- it still said 6.0.0 all the time since 6.0.0 (

70d1674

#9254) I've money-patched that for the release of tag v7.0.2 during the sign process. Co-authored-by: Juergen Weigert <jnweiger@gmail.com>

Bump ocis commit id for tests (#9277)

2dc80f6

Bump ocis commit id for tests

5da9ccd

Merge pull request #9287 from owncloud/bump-commit-id-for-tests-20230…

5dcfd4c

…623-stable [tests-only][full-ci]Bump commit id for tests

fix: use space name as page title

8391d00

fix: h1 uniqueness

5434cb2

fix: use h4 tag for title in OcInfoDrop

78cafa8

fix: make nav highlighter aria-hidden and move out of <ul>

9544908

fix: provide tile size slider id for label

c95858f

test: update snapshots

3a7aea2

fix: uploading to folders that contain special characters

25f54bd

Fixes uploading resources to folders that contain special characters in their names. This also includes fixes for name conflict handling when running oC10 as server.

Merge pull request #9113 from owncloud/some-a11y-fixes

cf247bd

Some a11y fixes

Bump ocis commit id for tests

542331b

Merge pull request #9306 from owncloud/bump-commit-id-for-tests-7bda0…

d60cc7c

…3c-stable [tests-only][full-ci] Bump ocis commit id for tests

Merge branch 'stable-7.0' into merge-stable-7.0-to-master-20230630

1f09b73

Remove duplicate pageTitle

a33c0e3

Shared with action menu label alignment

957d454

koebel added Status:Needs-Review Needs review from a maintainer Topic:UX-Design Category:Change Change existing functionality labels Jun 30, 2023

koebel requested a review from AlexAndBear June 30, 2023 10:07

koebel self-assigned this Jun 30, 2023

JammingBen added 2 commits June 30, 2023 13:04

Merge pull request #9322 from owncloud/merge-stable-7.0-to-master-202…

e93d276

…30630 Merge stable 7.0 to master

Automated changelog update [skip ci]

f09043d

phil-davis reviewed Jun 30, 2023

View reviewed changes

changelog/unreleased/bugfix-label-alignment Outdated Show resolved Hide resolved

Remove loadConfig helper function

794f432

Jan and others added 10 commits July 31, 2023 17:33

Show error message while accessing a public link which originated res…

3a312f8

…ource is deleted or disabled (space) (#9502) * Show error message while accessing a public link which originated resource is deleted or disabled (space) * Rm new line

Automated changelog update [skip ci]

8c23304

[tx] updated from transifex

82a2eab

Merge pull request #8770 from owncloud/typescript-5

ff5f387

chore: TypeScript 5

Use spaces endpoint for search (#9500)

2695720

* Use new spaces endpoint for search * Bump sdk and ocis commit id * Add spaces check

fix: ApplicationTranslations type

a471c4e

Merge pull request #9509 from owncloud/fix-applications-translations-…

6048434

…type fix: ApplicationTranslations type

[tx] updated from transifex

5429c42

[tx] updated from transifex

c7bddfe

JammingBen and others added 2 commits August 2, 2023 13:57

Fix typo in changelog item

b01f41a

Co-authored-by: Phil Davis <phil@jankaritech.com>

Merge branch 'shared-with-action-menu-label-alignment' of https://git…

4433ced

…hub.com/owncloud/web into shared-with-action-menu-label-alignment

bumped ocis commit id for tests (#9522)

3efbeb1

koebel and others added 3 commits August 2, 2023 16:46

Shared with action menu label alignment

54bdd38

Fix typo in changelog item

5aa2d1b

Co-authored-by: Phil Davis <phil@jankaritech.com>

Merge branch 'shared-with-action-menu-label-alignment' of https://git…

b339eb1

…hub.com/owncloud/web into shared-with-action-menu-label-alignment

koebel and others added 3 commits August 2, 2023 17:09

Shared with action menu label alignment

765daf4

Fix typo in changelog item

f9e5adf

Co-authored-by: Phil Davis <phil@jankaritech.com>

Merge branch 'shared-with-action-menu-label-alignment' of https://git…

06ccbeb

…hub.com/owncloud/web into shared-with-action-menu-label-alignment

JammingBen closed this Aug 2, 2023

koebel deleted the shared-with-action-menu-label-alignment branch August 2, 2023 14:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shared with action menu label alignment #9324

Shared with action menu label alignment #9324

koebel commented Jun 30, 2023

sonarcloud bot commented Jun 30, 2023

JammingBen commented Aug 2, 2023

koebel commented Aug 2, 2023

JammingBen commented Aug 2, 2023

JammingBen commented Aug 2, 2023

sonarcloud bot commented Aug 2, 2023

koebel commented Aug 2, 2023

JammingBen commented Aug 2, 2023

koebel commented Aug 2, 2023

koebel commented Aug 2, 2023

Shared with action menu label alignment #9324

Shared with action menu label alignment #9324

Conversation

koebel commented Jun 30, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

sonarcloud bot commented Jun 30, 2023

JammingBen commented Aug 2, 2023

koebel commented Aug 2, 2023

JammingBen commented Aug 2, 2023

JammingBen commented Aug 2, 2023

sonarcloud bot commented Aug 2, 2023

koebel commented Aug 2, 2023

JammingBen commented Aug 2, 2023

koebel commented Aug 2, 2023

koebel commented Aug 2, 2023