Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement password policy #9634

Merged
merged 29 commits into from
Sep 5, 2023
Merged

Implement password policy #9634

merged 29 commits into from
Sep 5, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Aug 31, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Aug 31, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title init Implement password policy Aug 31, 2023
@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Sep 4, 2023 •
edited
Loading

Known bug, focus trap in modal with input type password is broken 😿

JammingBen
JammingBen reviewed Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few nitpicks, looks great to me overall! Though I still have the wish for proper types for the rules and policies 🙂

packages/design-system/src/components/_OcTextInputPassword/_OcTextInputPassword.vue Outdated Show resolved Hide resolved
packages/web-pkg/src/services/passwordPolicy/passwordPolicy.ts Outdated Show resolved Hide resolved
packages/web-pkg/src/services/passwordPolicy/rules.ts Outdated Show resolved Hide resolved
packages/web-runtime/src/store/modal.ts Show resolved Hide resolved
@AlexAndBear
Copy link
Contributor Author

Typings and Unit Tests incoming 🐷

JammingBen
JammingBen approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlexAndBear AlexAndBear marked this pull request as ready for review September 5, 2023 14:50
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

29.4% 29.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AlexAndBear AlexAndBear merged commit fa792e0 into master Sep 5, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the password-policy branch September 5, 2023 15:38
@SwikritiT SwikritiT mentioned this pull request Sep 6, 2023
Closed
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@AlexAndBear
Implement password policy (#9634)
07d136f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 1-click option to copy link password [web] Validator for passwords
2 participants
@AlexAndBear @JammingBen