feat: add i18n support #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozomuikuta
commented
Nov 26, 2023
nozomuikuta
commented
Nov 26, 2023
ubugeeei
requested changes
Nov 26, 2023
There was a problem hiding this comment.
@nozomuikuta
I've left a few comments!
Whether to address them in this PR or to consider them separately, I'd like to leave that up to you.
I'm currently thinking of making some larger changes to tsconfig, prettier config, etc., so it might be helpful for me if this gets merged first.
Closed
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13
I added fundamental code for i18n support.
Once this PR is merged, we can start Japanese translation.
I already translated
/src/ja/docs/index.mdfor demonstration.I will add some inline comments.