Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): refine locale config #39

Merged
merged 1 commit into from
Nov 30, 2023
Merged

chore(core): refine locale config #39

merged 1 commit into from
Nov 30, 2023

Conversation

nozomuikuta
Copy link
Contributor

@nozomuikuta nozomuikuta commented Nov 30, 2023

Related to #14, #27

  • Define as much config as possible at locale level
    • With this PR we can set up OG/Twitter config for each locale
  • Provide defineLocaleConfig function for better DX
    • Some OG/Twitter are automatically set so that we don't have to copy and paste string literals (if set, error is thrown and we can fail fast during development)
  • Add titleTemplate to index.md and ja/index.md to override titleTemplate in config.ts, because interpolation of :title is not necessary

Once CI is passed, let me merge this PR immediately.

@nozomuikuta nozomuikuta self-assigned this Nov 30, 2023
@nozomuikuta
Copy link
Contributor Author

nozomuikuta commented Nov 30, 2023

Hmm, labels are not set automatically.
I guess this is due to actions/labeler#423.

The author says it will be fixed in the new version which is currently beta.
So, at the moment, if we edit files whose mapping of label and paths conflicts with others, we have to add labels by ourselves.

I created a follow-up issue: #40

@nozomuikuta nozomuikuta added core Related to Application itself lang:en Related to English contents lang:ja Related to Japanese contents labels Nov 30, 2023
@nozomuikuta nozomuikuta merged commit 6e9e76b into main Nov 30, 2023
9 checks passed
@nozomuikuta nozomuikuta deleted the chore/i18n-meta branch November 30, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to Application itself lang:en Related to English contents lang:ja Related to Japanese contents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant