Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 4, 2025

refs #758
fixes, vitejs/rolldown-vite#477

The tests passes without the change, but covers the new if. To make a test that fails, we need to configure the cwd to a different path, but that makes the test more complex, so I didn't do that.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.79%. Comparing base (c605843) to head (7ea7e65).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #809      +/-   ##
==========================================
+ Coverage   93.63%   93.79%   +0.15%     
==========================================
  Files          17       17              
  Lines        3095     3092       -3     
==========================================
+ Hits         2898     2900       +2     
+ Misses        197      192       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sapphi-red sapphi-red requested a review from Boshen November 4, 2025 13:26
@sapphi-red sapphi-red marked this pull request as ready for review November 4, 2025 13:26
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 4, 2025

CodSpeed Performance Report

Merging #809 will not alter performance

Comparing 11-04-fix_skip_loading_tsconfig.json_from_virtual_module_paths (7ea7e65) with main (c957d95)1

Summary

✅ 10 untouched
⏩ 5 skipped2

Footnotes

  1. No successful run was found on main (7ea7e65) during the generation of this report, so c957d95 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen added the merge label Nov 4, 2025
Copy link
Member

Boshen commented Nov 4, 2025

Merge activity

refs #758
fixes, vitejs/rolldown-vite#477

The tests passes without the change, but covers the new `if`. To make a test that fails, we need to configure the cwd to a different path, but that makes the test more complex, so I didn't do that.
@graphite-app graphite-app bot force-pushed the 11-04-fix_skip_loading_tsconfig.json_from_virtual_module_paths branch from 393c5c7 to 7ea7e65 Compare November 4, 2025 15:08
@graphite-app graphite-app bot merged commit 7ea7e65 into main Nov 4, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 11-04-fix_skip_loading_tsconfig.json_from_virtual_module_paths branch November 4, 2025 15:12
@Boshen Boshen mentioned this pull request Nov 4, 2025
@graphite-app graphite-app bot removed the merge label Nov 4, 2025
@Boshen Boshen mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants