-
-
Notifications
You must be signed in to change notification settings - Fork 33
feat: add tsconfig discovery #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
- Coverage 94.19% 94.03% -0.16%
==========================================
Files 16 16
Lines 3031 3069 +38
==========================================
+ Hits 2855 2886 +31
- Misses 176 183 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #758 will degrade performances by 5.16%Comparing Summary
Benchmarks breakdown
Footnotes
|
9119051 to
1da68af
Compare
|
@sapphi-red the code is a bit convoluted right but I plan to clean things up after this is merged and shipped, getting burned out from all the relevant changes already. Please let me know if I missed anything obvious. |
sapphi-red
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me.
The remaining feature needed for Vite is respecting include & exclude & references (rolldown/rolldown#5867).
Merge activity
|
## Summary Add automatic tsconfig.json discovery that traverses up parent directories, similar to how package.json is discovered. closes #626 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Rolldown PR: rolldown/rolldown#6602 Oxlint PR: oxc-project/oxc#14721
1da68af to
0e1674a
Compare
|
FWIW this broke the Rust options shape a bit and I had to update it on my end: - tsconfig: resolved_tsconfig.map(|config_file| TsconfigOptions {
+ tsconfig: resolved_tsconfig.map(|config_file| {
+ TsconfigDiscovery::Manual(TsconfigOptions {
config_file,
references: TsconfigReferences::Auto,
+ })
}), |
Sorry for the inconvenience, I stopped bumping majors for breaking Rust APIs because people complained that I change major versions too much - the reason we are at v11. |
refs #758 fixes, vitejs/rolldown-vite#477 The tests passes without the change, but covers the new `if`. To make a test that fails, we need to configure the cwd to a different path, but that makes the test more complex, so I didn't do that.
Summary
Add automatic tsconfig.json discovery that traverses up parent directories, similar to how package.json is discovered.
closes #626
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Rolldown PR: rolldown/rolldown#6602
Oxlint PR: oxc-project/oxc#14721