Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Oct 16, 2025

Summary

Add automatic tsconfig.json discovery that traverses up parent directories, similar to how package.json is discovered.

closes #626

🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

Rolldown PR: rolldown/rolldown#6602
Oxlint PR: oxc-project/oxc#14721

@graphite-app
Copy link

graphite-app bot commented Oct 16, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@Boshen Boshen marked this pull request as draft October 16, 2025 08:15
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.03%. Comparing base (6b9a7cf) to head (0e1674a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 87.23% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
- Coverage   94.19%   94.03%   -0.16%     
==========================================
  Files          16       16              
  Lines        3031     3069      +38     
==========================================
+ Hits         2855     2886      +31     
- Misses        176      183       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 16, 2025

CodSpeed Performance Report

Merging #758 will degrade performances by 5.16%

Comparing feat/tsconfig-discovery (0e1674a) with main (6b9a7cf)

Summary

❌ 1 regression
✅ 6 untouched
⏩ 2 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
large 26.5 µs 27.9 µs -5.16%

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen changed the title feat: add tsconfig discovery and return from Resolution feat: add tsconfig discovery Oct 16, 2025
@Boshen Boshen force-pushed the feat/tsconfig-discovery branch 2 times, most recently from 9119051 to 1da68af Compare October 17, 2025 08:04
@Boshen Boshen requested a review from sapphi-red October 17, 2025 09:06
@Boshen
Copy link
Member Author

Boshen commented Oct 17, 2025

@sapphi-red the code is a bit convoluted right but I plan to clean things up after this is merged and shipped, getting burned out from all the relevant changes already.

Please let me know if I missed anything obvious.

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

The remaining feature needed for Vite is respecting include & exclude & references (rolldown/rolldown#5867).

@Boshen Boshen marked this pull request as ready for review October 17, 2025 10:39
@Boshen Boshen added the merge label Oct 17, 2025
Copy link
Member Author

Boshen commented Oct 17, 2025

Merge activity

## Summary

Add automatic tsconfig.json discovery that traverses up parent directories, similar to how package.json is discovered.

closes #626

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Rolldown PR: rolldown/rolldown#6602
Oxlint PR: oxc-project/oxc#14721
@graphite-app graphite-app bot force-pushed the feat/tsconfig-discovery branch from 1da68af to 0e1674a Compare October 17, 2025 10:40
@graphite-app graphite-app bot merged commit 0e1674a into main Oct 17, 2025
15 of 16 checks passed
@graphite-app graphite-app bot deleted the feat/tsconfig-discovery branch October 17, 2025 10:44
@Boshen Boshen mentioned this pull request Oct 17, 2025
@graphite-app graphite-app bot removed the merge label Oct 17, 2025
@bluwy
Copy link

bluwy commented Oct 21, 2025

FWIW this broke the Rust options shape a bit and I had to update it on my end:

-           tsconfig: resolved_tsconfig.map(|config_file| TsconfigOptions {
+           tsconfig: resolved_tsconfig.map(|config_file| {
+               TsconfigDiscovery::Manual(TsconfigOptions {
                    config_file,
                    references: TsconfigReferences::Auto,
+               })
            }),

@Boshen
Copy link
Member Author

Boshen commented Oct 21, 2025

FWIW this broke the Rust options shape a bit and I had to update it on my end:

-           tsconfig: resolved_tsconfig.map(|config_file| TsconfigOptions {
+           tsconfig: resolved_tsconfig.map(|config_file| {
+               TsconfigDiscovery::Manual(TsconfigOptions {
                    config_file,
                    references: TsconfigReferences::Auto,
+               })
            }),

Sorry for the inconvenience, I stopped bumping majors for breaking Rust APIs because people complained that I change major versions too much - the reason we are at v11.

@Boshen Boshen mentioned this pull request Oct 21, 2025
graphite-app bot pushed a commit that referenced this pull request Nov 4, 2025
refs #758
fixes, vitejs/rolldown-vite#477

The tests passes without the change, but covers the new `if`. To make a test that fails, we need to configure the cwd to a different path, but that makes the test more complex, so I didn't do that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tsconfig discovery

5 participants