Skip to content

chore(linter): bump oxc_resolver #14721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

chore(linter): bump oxc_resolver #14721

merged 1 commit into from
Oct 21, 2025

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Oct 17, 2025 •
edited
Loading

This is incomplete.

@Boshen Boshen requested a review from camc314 as a code owner October 17, 2025 08:35
Copilot AI review requested due to automatic review settings October 17, 2025 08:35
@Boshen Boshen marked this pull request as draft October 17, 2025 08:35
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 17, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Oct 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI reviewed Oct 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enable automatic tsconfig discovery in the linter’s module resolver and deprecate the manual --tsconfig option.

  • Switch resolver configuration to use TsconfigDiscovery::Auto.
  • Change extension alias behavior to always apply .js/.mjs/.cjs -> .ts/.mts/.cts mapping.
  • Temporarily point oxc_resolver to a feature branch to consume the new API.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
crates/oxc_linter/src/service/runtime.rs Update resolver setup to use TsconfigDiscovery::Auto and make extension alias unconditional.
Cargo.toml Point oxc_resolver to a git branch providing tsconfig discovery.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14721 will not alter performance

Comparing 10-17-feat_linter_automatic_tsconfig_discovery_deprecate_--tsconfig_option (707bf07) with main (7a420a1)

Summary

✅ 37 untouched

@Boshen Boshen mentioned this pull request Oct 17, 2025
Merged
graphite-app bot pushed a commit to oxc-project/oxc-resolver that referenced this pull request Oct 17, 2025
@Boshen
feat: add tsconfig discovery (#758)
0e1674a 
## Summary

Add automatic tsconfig.json discovery that traverses up parent directories, similar to how package.json is discovered.

closes #626

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Rolldown PR: rolldown/rolldown#6602
Oxlint PR: oxc-project/oxc#14721
@Boshen Boshen force-pushed the 10-17-feat_linter_automatic_tsconfig_discovery_deprecate_--tsconfig_option branch from 780ceea to 707bf07 Compare October 21, 2025 03:10
@Boshen Boshen changed the title feat(linter)!: automatic tsconfig discovery; deprecate --tsconfig option chore(linter): bump oxc_resolver Oct 21, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Oct 21, 2025
@Boshen Boshen marked this pull request as ready for review October 21, 2025 03:11
@Boshen
Copy link
Member Author

Boshen commented Oct 21, 2025

@camc314 I decided to defer the decision on auto tsconfig discovery.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Oct 21, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 10-17-feat_linter_automatic_tsconfig_discovery_deprecate_--tsconfig_option branch from 707bf07 to d0faa7c Compare October 21, 2025 03:16
@graphite-app graphite-app bot merged commit d0faa7c into main Oct 21, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-17-feat_linter_automatic_tsconfig_discovery_deprecate_--tsconfig_option branch October 21, 2025 03:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

No one assigned

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen