New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support import attributes in TS import type #2394

Closed

ArnaudBarre opened this issue Feb 11, 2024 · 2 comments · Fixed by #2436

Assignees

Contributor

ArnaudBarre commented Feb 11, 2024

It was probably missed in #1476 cc @magic-akari

I don't know if this is actually used, found it when exploring the difference between Oxc and TSESTree.

Boshen self-assigned this

Collaborator

magic-akari commented Feb 13, 2024

If TypeScript supports this syntax, I believe we should adopt it as well.

Member

Dunqing commented Feb 18, 2024

Do you have time to do this? If not, I'm interested in taking over @Boshen

Boshen assigned Dunqing and unassigned Boshen

Dunqing mentioned this issue

feat(parser): parse import attributes in TSImportType #2436

Merged

Boshen closed this as completed in #2436

Boshen pushed a commit that referenced this issue


          feat(parser): parse import attributes in TSImportType (#2436)

60db720

close: #2394 

https://github.com/microsoft/TypeScript/blob/64d2eeea7b9c7f1a79edf42cb99f302535136a2e/src/compiler/types.ts#L2177-L2185

The corresponding test cases were skipped, so I manually added some
cases to misc

https://github.com/oxc-project/oxc/blob/f5db48237ff774d778bdb48e13950b5a8876f361/tasks/coverage/src/typescript.rs#L118-L121

IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue


          feat(parser): parse import attributes in TSImportType (oxc-project#2436)

7e409f2

close: oxc-project#2394 

https://github.com/microsoft/TypeScript/blob/64d2eeea7b9c7f1a79edf42cb99f302535136a2e/src/compiler/types.ts#L2177-L2185

The corresponding test cases were skipped, so I manually added some
cases to misc

https://github.com/oxc-project/oxc/blob/f5db48237ff774d778bdb48e13950b5a8876f361/tasks/coverage/src/typescript.rs#L118-L121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment