feat(ast): implement new proposal-import-attributes

[magic-akari]

• Import Attributes

[magic-akari]

Current dependencies on/for this PR:

• main
  • PR feat(ast): implement new proposal-import-attributes #1476 👈

This stack of pull requests is managed by Graphite.

[Boshen]

Is this another stage3 feature without test262 tests? We'll leave this as draft if this is the case :-(

[Boshen]

I think I should write a rule for what ecma features we support at some point :-/

[magic-akari]

I implemented it after reading the TypeScript Release Note 🤣

[Boshen]

I implemented it after reading the TypeScript Release Note 🤣

Stage 3 features can only be advanced to stage 4 when babel / typescript have implementations. I'm being more conservative around stage 3 features.

[magic-akari]

I found the test cases in test262.
https://github.com/tc39/test262/blob/main/test/language/import/import-attributes/json-extensibility-array.js

[codspeed-hq]

CodSpeed Performance Report

Merging #1476 will not alter performance

_{Comparing ast/proposal-import-attributes (7f2deca) with main (13cac62)}

Summary

✅ 20 untouched benchmarks

[Boshen]

I found the test cases in test262. https://github.com/tc39/test262/blob/main/test/language/import/import-attributes/json-extensibility-array.js

Nice finding!

Let's update our submodule and remove this

oxc/tasks/coverage/src/test262.rs

Line 163 in 924d99e

"json-modules",

[Boshen]

I found the test cases in test262. https://github.com/tc39/test262/blob/main/test/language/import/import-attributes/json-extensibility-array.js

Nice finding!

Let's update our submodule and remove this

oxc/tasks/coverage/src/test262.rs

Line 163 in 924d99e

"json-modules",

If I recall correctly, it was removed because it requires a resolver to statically check if the import is actually a json ... which is super weird for a parsing test.

[Boshen]

Nice work! Thank you for bearing with me.