-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
☂️ eslint-plugin-unicorn #684
Labels
A-linter
Area - Linter
E-Help Wanted
Experience level - For the experienced collaborators
good first issue
Experience Level - Good for newcomers
Comments
Boshen
changed the title
https://github.com/sindresorhus/eslint-plugin-unicorn (recommended)
☂️ linter: eslint-plugin-unicorn
Aug 4, 2023
Boshen
changed the title
☂️ linter: eslint-plugin-unicorn
☂️ linter: eslint-plugin-unicorn (recommended)
Aug 4, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There are some convention / style rules, which should be omitted from the list. We should aim for correctness rules. |
Boshen
pushed a commit
that referenced
this issue
Aug 17, 2023
implement [eslint-plugin-unicorn/no-instanceof-array](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-instanceof-array.md). Related issue: #684
Boshen
pushed a commit
that referenced
this issue
Sep 4, 2023
Boshen
pushed a commit
that referenced
this issue
Sep 16, 2023
Boshen
pushed a commit
that referenced
this issue
Oct 16, 2023
Boshen
pushed a commit
that referenced
this issue
Oct 17, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Boshen
pushed a commit
that referenced
this issue
Oct 27, 2023
Boshen
pushed a commit
that referenced
this issue
Oct 28, 2023
…gument (#1073) Rule taken from #684. Tests taken from: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/test/require-number-to-fixed-digits-argument.mjs Another rule! 😄
This comment was marked as resolved.
This comment was marked as resolved.
Boshen
pushed a commit
that referenced
this issue
Oct 30, 2023
IWANABETHATGUY
added a commit
that referenced
this issue
Dec 3, 2023
Boshen
pushed a commit
that referenced
this issue
Dec 5, 2023
Boshen
pushed a commit
that referenced
this issue
Dec 5, 2023
[Rule](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/explicit-length-check.md) #684 It's harder than I thought. Test cases that require a vue parser have been skipped Some test case needs [getStaticValue](https://github.com/eslint-community/eslint-utils/blob/main/src/get-static-value.mjs#L672) to pass.
This was referenced Dec 9, 2023
camc314
pushed a commit
that referenced
this issue
Dec 13, 2023
…e) (#1658) Implement [prefer-dom-node-text-content](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-text-content.md) for #684 .
camc314
pushed a commit
that referenced
this issue
Dec 17, 2023
@NikitaIT Can you create an separate issue and provide more context? |
Boshen
changed the title
☂️ linter: eslint-plugin-unicorn (recommended)
☂️ eslint-plugin-unicorn
Jan 26, 2024
Boshen
pushed a commit
that referenced
this issue
Feb 16, 2024
Part of #684 - docs: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-process-exit.md - source: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/rules/no-process-exit.js - tests: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/test/no-process-exit.mjs
Dunqing
pushed a commit
that referenced
this issue
Apr 14, 2024
Boshen
added a commit
that referenced
this issue
May 12, 2024
Refer to [eslint-plugin-unicorn/no-anonymous-default-export](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v52.0.0/docs/rules/no-anonymous-default-export.md) link: #684 --------- Co-authored-by: Boshen <boshenc@gmail.com>
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/oxc
that referenced
this issue
May 29, 2024
) Part of oxc-project#684 - docs: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-process-exit.md - source: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/rules/no-process-exit.js - tests: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/test/no-process-exit.mjs
This was referenced Oct 16, 2024
DonIsaac
added a commit
that referenced
this issue
Oct 20, 2024
[unicorn/consistent-empty-array-spread](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v56.0.0/docs/rules/consistent-empty-array-spread.md) of #684 --------- Co-authored-by: Brian Liu <brian@redflagsdating.com> Co-authored-by: Don Isaac <donald.isaac@gmail.com>
DonIsaac
added a commit
that referenced
this issue
Oct 20, 2024
[unicorn/prefer-math-min-max](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v56.0.0/docs/rules/prefer-math-min-max.md) of #684 --------- Co-authored-by: Brian Liu <brian@redflagsdating.com> Co-authored-by: Don Isaac <donald.isaac@gmail.com> Co-authored-by: Cam McHenry <camchenry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-linter
Area - Linter
E-Help Wanted
Experience level - For the experienced collaborators
good first issue
Experience Level - Good for newcomers
Warning
This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules
This is tracking issue for
eslint-plugin-unicorn
.There are 123(+ 17 deprecated) rules.
To get started, run the following command:
Then register the rule in
crates/oxc_linter/src/rules.rs
and alsodeclare_all_lint_rules
at the bottom.Recommended rules
✨: 88, 🚫: 0 / total: 115
✨ = Implemented, 🚫 = No need to implement
Not recommended rules
✨: 0, 🚫: 0 / total: 8
✨ = Implemented, 🚫 = No need to implement
Deprecated rules
✨: 0, 🚫: 0 / total: 17
✨ = Implemented, 🚫 = No need to implement
The text was updated successfully, but these errors were encountered: