Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add unicorn/prefer-negative-index #6920

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

LBrian
Copy link
Contributor

@LBrian LBrian commented Oct 26, 2024

Copy link

graphite-app bot commented Oct 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Oct 26, 2024
@LBrian LBrian changed the title Added unicorn/prefer-negative-index feat(linter): add unicorn/prefer-negative-index Oct 26, 2024
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Oct 26, 2024
Copy link

codspeed-hq bot commented Oct 26, 2024

CodSpeed Performance Report

Merging #6920 will not alter performance

Comparing LBrian:feat/684-prefer-negative-index (6d407f9) with main (f0643c4)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac changed the title feat(linter): add unicorn/prefer-negative-index feat(linter): add unicorn/prefer-negative-index Oct 26, 2024
@Boshen Boshen requested a review from camc314 November 25, 2024 08:47
@Boshen
Copy link
Member

Boshen commented Nov 25, 2024

@camc314 can you help and get this merged.

@camc314 camc314 force-pushed the feat/684-prefer-negative-index branch from 30935ca to 27a734a Compare November 25, 2024 08:49
@camc314 camc314 self-assigned this Nov 25, 2024
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@camc314
Copy link
Contributor

camc314 commented Nov 25, 2024

hmm ci is failing

Run npx -y -p typescript tsc --lib es2020,dom npm/oxc-wasm/oxc_wasm.d.ts
Error: npm/oxc-wasm/oxc_wasm.d.ts(69,36): error TS2307: Cannot find module '@oxc-project/types' or its corresponding type declarations.
Error: npm/oxc-wasm/oxc_wasm.d.ts(70,15): error TS2307: Cannot find module '@oxc-project/types' or its corresponding type declarations.
Error: Process completed with exit code 2.

@camc314 camc314 force-pushed the feat/684-prefer-negative-index branch from 7f16c18 to 6d407f9 Compare November 25, 2024 09:17
@camc314 camc314 merged commit 0b9da38 into oxc-project:main Nov 25, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants