-
-
Notifications
You must be signed in to change notification settings - Fork 737
fix(linter): Make extended configs properly inherit plugins #10174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): Make extended configs properly inherit plugins #10174
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
Haven't had a chance to review this yet, but I will take a look next time I am able. |
camchenry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests look good, but let's refactor it to not need an extra dependency, to help keep things simpler
CodSpeed Instrumentation Performance ReportMerging #10174 will not alter performanceComparing Summary
|
|
@camchenry Could you also take a look at #10157 please? Its another fix for nested config |
camchenry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates!
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link |
|
@camchenry Could you help with the graphite-app comment above? I've configured the account so I'm guessing we'll need to re-add the label. Thanks! |
Fixes #10173
When extending configuration files in Oxlint, plugins from the extended config were not being properly inherited, which caused rules requiring those plugins to be filtered out. This was encountered in issue #10173 where rules like vitest/no-focused-tests were being ignored even when the vitest plugin was defined in a base configuration.
The issue occurred because in the implementation of from_oxlintrc. The following changes were made:
Modified plugin inheritance logic in from_oxlintrc:
Added tests to verify the behavior:
This ensures that when rules are added from an extended config, the necessary plugins are already enabled, so the rules won't be filtered out in the build step.
cc @camchenry