-
-
Notifications
You must be signed in to change notification settings - Fork 737
fix(linter): Make extended configs properly inherit plugins #10174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
camchenry
merged 10 commits into
oxc-project:main
from
zubhav:fix-10173-extended-config-plugin-inheritance
Apr 9, 2025
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7350a99
Add tempfile dependency and fix plugin inheritance bug
zubhav a2d6af1
Refactor plugin filtering logic for stale cache
zubhav 534fccf
Refactor filtering rules by plugin name in config_builder
zubhav e283010
Handle plugin inheritance in config builder
zubhav 213e0cd
Merge branch 'main' into fix-10173-extended-config-plugin-inheritance
zubhav dc146df
[autofix.ci] apply automated fixes
autofix-ci[bot] e9ef8b3
Add new child config files for extending parent plugins
zubhav 33d206e
Merge branch 'main' into fix-10173-extended-config-plugin-inheritance
zubhav 195dd79
[autofix.ci] apply automated fixes
autofix-ci[bot] 08aa912
Merge branch 'main' into fix-10173-extended-config-plugin-inheritance
zubhav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
crates/oxc_linter/fixtures/extends_config/plugins/child_no_plugins.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "extends": [ | ||
| "parent.json" | ||
| ] | ||
| } |
8 changes: 8 additions & 0 deletions
8
crates/oxc_linter/fixtures/extends_config/plugins/child_with_plugins.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "extends": [ | ||
| "parent.json" | ||
| ], | ||
| "plugins": [ | ||
| "jest" | ||
| ] | ||
| } |
6 changes: 6 additions & 0 deletions
6
crates/oxc_linter/fixtures/extends_config/plugins/parent.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "plugins": [ | ||
| "react", | ||
| "typescript" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.