-
-
Notifications
You must be signed in to change notification settings - Fork 736
refactor(transformer/typescript): simplify TypeScriptAnnotations::has_value_reference method
#10349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method
Apr 11, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This was referenced Apr 10, 2025
CodSpeed Instrumentation Performance ReportMerging #10349 will not alter performanceComparing Summary
|
8790921 to
e82bd5c
Compare
678454b to
0a2fed4
Compare
e82bd5c to
f5bdc37
Compare
This was referenced Apr 11, 2025
0081548 to
d67b558
Compare
946b095 to
40c2330
Compare
This was referenced Apr 11, 2025
d67b558 to
f41abc2
Compare
40c2330 to
896f560
Compare
Contributor
Merge activity
|
…s_value_reference` method (#10349) We already have a `BindingIdentifier`, so we don't need to get the symbol ID by `get_root_binding` again.
f41abc2 to
4c14d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ast
Area - AST
A-semantic
Area - Semantic
A-transformer
Area - Transformer / Transpiler
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

We already have a
BindingIdentifier, so we don't need to get the symbol ID byget_root_bindingagain.