Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 10, 2025

We already have a BindingIdentifier, so we don't need to get the symbol ID by get_root_binding again.

Copy link
Member Author

Dunqing commented Apr 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 10, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 10, 2025

CodSpeed Instrumentation Performance Report

Merging #10349 will not alter performance

Comparing 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method (4c14d0b) with main (1a37e3f)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing force-pushed the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch from 8790921 to e82bd5c Compare April 10, 2025 11:36
@Dunqing Dunqing force-pushed the 04-10-refactor_semantic_simplify_bind_logic_for_tsmoduledeclaration branch from 678454b to 0a2fed4 Compare April 10, 2025 11:36
@Dunqing Dunqing changed the base branch from 04-10-refactor_semantic_simplify_bind_logic_for_tsmoduledeclaration to graphite-base/10349 April 11, 2025 01:54
@Dunqing Dunqing force-pushed the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch from e82bd5c to f5bdc37 Compare April 11, 2025 01:54
@Dunqing Dunqing changed the base branch from graphite-base/10349 to 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier April 11, 2025 01:54
@Dunqing Dunqing force-pushed the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch 2 times, most recently from 0081548 to d67b558 Compare April 11, 2025 07:15
@Dunqing Dunqing force-pushed the 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier branch from 946b095 to 40c2330 Compare April 11, 2025 07:15
@Dunqing Dunqing marked this pull request as ready for review April 11, 2025 08:34
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 11, 2025 08:34
@Dunqing Dunqing changed the base branch from 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier to graphite-base/10349 April 11, 2025 09:47
@Dunqing Dunqing force-pushed the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch from d67b558 to f41abc2 Compare April 11, 2025 09:48
@Dunqing Dunqing force-pushed the graphite-base/10349 branch from 40c2330 to 896f560 Compare April 11, 2025 09:48
@Dunqing Dunqing changed the base branch from graphite-base/10349 to 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier April 11, 2025 09:48
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
@graphite-app graphite-app bot changed the base branch from 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier to graphite-base/10349 April 11, 2025 09:59
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 11, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/10349 to main April 11, 2025 10:15
@graphite-app graphite-app bot requested a review from Boshen as a code owner April 11, 2025 10:15
@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST labels Apr 11, 2025
…s_value_reference` method (#10349)

We already have a `BindingIdentifier`, so we don't need to get the symbol ID by `get_root_binding` again.
@graphite-app graphite-app bot force-pushed the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch from f41abc2 to 4c14d0b Compare April 11, 2025 10:16
@graphite-app graphite-app bot merged commit 4c14d0b into main Apr 11, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch April 11, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants