Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 11, 2025

It seems that as ⁠Semantic gradually improves, many checks and special handling will no longer be necessary.

Copy link
Member Author

Dunqing commented Apr 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 11, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Instrumentation Performance Report

Merging #10359 will create unknown performance changes

Comparing 04-11-refactor_transformer_typescript_remove_unnecessary_specific_handling_of_tsmoduleddeclaration_transformation (7508a43) with main (62f35bc)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.2 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.1 ms N/A
🆕 formatter[antd.js] N/A 638.4 ms N/A
🆕 formatter[react.development.js] N/A 6.1 ms N/A
🆕 formatter[typescript.js] N/A 815.4 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.4 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.3 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.9 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 15.9 ms N/A
🆕 mangler[react.development.js] N/A 293.4 µs N/A
🆕 mangler[typescript.js] N/A 39.4 ms N/A
🆕 minifier[antd.js] N/A 165.3 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.3 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing Dunqing marked this pull request as ready for review April 11, 2025 08:46
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 11, 2025 08:46
@Dunqing Dunqing changed the base branch from 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration to graphite-base/10359 April 11, 2025 09:44
@Dunqing Dunqing changed the base branch from graphite-base/10359 to 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration April 11, 2025 09:44
@Dunqing Dunqing changed the base branch from 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration to graphite-base/10359 April 11, 2025 09:47
@Dunqing Dunqing changed the base branch from graphite-base/10359 to 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration April 11, 2025 09:48
@Dunqing Dunqing changed the base branch from 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration to graphite-base/10359 April 11, 2025 09:48
@Dunqing Dunqing force-pushed the graphite-base/10359 branch from efaa721 to b89e69c Compare April 11, 2025 09:49
@Dunqing Dunqing force-pushed the 04-11-refactor_transformer_typescript_remove_unnecessary_specific_handling_of_tsmoduleddeclaration_transformation branch from 7b28fb0 to 0d965d9 Compare April 11, 2025 09:49
@Dunqing Dunqing changed the base branch from graphite-base/10359 to 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule April 11, 2025 09:49
@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from b89e69c to 16606b1 Compare April 11, 2025 10:29
@graphite-app graphite-app bot requested a review from Boshen as a code owner April 11, 2025 10:29
@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_remove_unnecessary_specific_handling_of_tsmoduleddeclaration_transformation branch from 0d965d9 to df49d09 Compare April 11, 2025 10:30
@Dunqing Dunqing changed the title refactor(transformer/typescript): simplify transforming TSModuleDeclaration refactor(transformer/typescript): remove unnecessary specific handling of TSModuleDeclaration transformation Apr 11, 2025
@Dunqing Dunqing force-pushed the 04-11-refactor_transformer_typescript_remove_unnecessary_specific_handling_of_tsmoduleddeclaration_transformation branch from df49d09 to f046d51 Compare April 12, 2025 11:37
@Dunqing Dunqing force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from 16606b1 to 13126c1 Compare April 12, 2025 11:37
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 12, 2025
Copy link
Member

Boshen commented Apr 12, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from 13126c1 to cbb8d33 Compare April 12, 2025 13:40
graphite-app bot pushed a commit that referenced this pull request Apr 12, 2025
…g of `TSModuleDeclaration` transformation (#10359)

It seems that as ⁠`Semantic` gradually improves, many checks and special handling will no longer be necessary.
@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_remove_unnecessary_specific_handling_of_tsmoduleddeclaration_transformation branch from f046d51 to 3d5dc44 Compare April 12, 2025 13:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 12, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 13, 2025
@Dunqing Dunqing force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from cbb8d33 to 9de9c6c Compare April 14, 2025 02:39
Dunqing added a commit that referenced this pull request Apr 14, 2025
…g of `TSModuleDeclaration` transformation (#10359)

It seems that as ⁠`Semantic` gradually improves, many checks and special handling will no longer be necessary.
@Dunqing Dunqing force-pushed the 04-11-refactor_transformer_typescript_remove_unnecessary_specific_handling_of_tsmoduleddeclaration_transformation branch from 3d5dc44 to 9e9e29f Compare April 14, 2025 02:48
@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule branch from 9de9c6c to 032377d Compare April 14, 2025 02:49
graphite-app bot pushed a commit that referenced this pull request Apr 14, 2025
…g of `TSModuleDeclaration` transformation (#10359)

It seems that as ⁠`Semantic` gradually improves, many checks and special handling will no longer be necessary.
@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_remove_unnecessary_specific_handling_of_tsmoduleddeclaration_transformation branch from 9e9e29f to cbfa609 Compare April 14, 2025 02:49
Base automatically changed from 04-11-refactor_transformer_typescript_do_not_need_to_go_through_tsmoduledeclaration_if_is_a_namespacemodule to main April 14, 2025 02:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 14, 2025
…g of `TSModuleDeclaration` transformation (#10359)

It seems that as ⁠`Semantic` gradually improves, many checks and special handling will no longer be necessary.
@graphite-app graphite-app bot force-pushed the 04-11-refactor_transformer_typescript_remove_unnecessary_specific_handling_of_tsmoduleddeclaration_transformation branch from cbfa609 to 7508a43 Compare April 14, 2025 02:58
@graphite-app graphite-app bot merged commit 7508a43 into main Apr 14, 2025
30 checks passed
@graphite-app graphite-app bot deleted the 04-11-refactor_transformer_typescript_remove_unnecessary_specific_handling_of_tsmoduleddeclaration_transformation branch April 14, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants