Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jun 29, 2025

part of #11490

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jun 29, 2025
Copy link
Contributor Author

camc314 commented Jun 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review June 29, 2025 14:58
@camc314 camc314 changed the base branch from c/06-29-refactor_ast_add_astkind_for_tsconstructortype_ to graphite-base/11966 June 29, 2025 15:00
@camc314 camc314 changed the title refactor(ast): add astkind for TSIndexSignature refactor(ast): add AstKind for TSIndexSignature Jun 29, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 29, 2025

CodSpeed Instrumentation Performance Report

Merging #11966 will degrade performances by 13.01%

Comparing c/06-29-refactor_ast_add_astkind_for_tsindexsignature_ (3f50cef) with main (03bce3f)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.5 ms -13.01%

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
Copy link
Contributor Author

camc314 commented Jun 29, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Jun 29, 2025
@graphite-app graphite-app bot force-pushed the c/06-29-refactor_ast_add_astkind_for_tsindexsignature_ branch from 19f2c78 to a777eb4 Compare June 29, 2025 16:28
@github-actions github-actions bot added the A-linter Area - Linter label Jun 29, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/11966 to c/06-29-refactor_ast_add_astkind_for_tsconstructortype_ June 29, 2025 16:29
Base automatically changed from c/06-29-refactor_ast_add_astkind_for_tsconstructortype_ to main June 29, 2025 16:35
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
@camc314 camc314 force-pushed the c/06-29-refactor_ast_add_astkind_for_tsindexsignature_ branch from a777eb4 to cbbc20b Compare June 29, 2025 17:15
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
@graphite-app graphite-app bot force-pushed the c/06-29-refactor_ast_add_astkind_for_tsindexsignature_ branch from cbbc20b to 3f50cef Compare June 29, 2025 17:24
@graphite-app graphite-app bot merged commit 3f50cef into main Jun 29, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
@graphite-app graphite-app bot deleted the c/06-29-refactor_ast_add_astkind_for_tsindexsignature_ branch June 29, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants