Skip to content

refactor(ast): add AstKind for BindingProperty #11974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

refactor(ast): add AstKind for BindingProperty #11974

merged 1 commit into from
Jun 30, 2025

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jun 29, 2025

No description provided.

This was referenced Jun 29, 2025
Merged
Merged
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter labels Jun 29, 2025
@camc314 camc314 mentioned this pull request Jun 29, 2025
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jun 29, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jun 29, 2025
@camc314 camc314 marked this pull request as ready for review June 29, 2025 17:15
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 29, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11974 will not alter performance

Comparing c/06-29-refactor_ast_add_astkind_for_bindingproperty_ (54582cb) with main (aa4020f)

Summary

✅ 38 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from c/06-29-refactor_ast_add_astkind_for_tsinterfacebody_ to graphite-base/11974 June 29, 2025 17:24
@graphite-app graphite-app bot force-pushed the graphite-base/11974 branch from 8e45e28 to 9f6784a Compare June 29, 2025 17:33
@graphite-app graphite-app bot force-pushed the c/06-29-refactor_ast_add_astkind_for_bindingproperty_ branch from a1cf307 to 70f54f1 Compare June 29, 2025 17:33
@graphite-app graphite-app bot changed the base branch from graphite-base/11974 to main June 29, 2025 17:34
@graphite-app graphite-app bot force-pushed the c/06-29-refactor_ast_add_astkind_for_bindingproperty_ branch from 70f54f1 to 0d1d373 Compare June 29, 2025 17:34
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jun 29, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jun 29, 10:53 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 29, 10:53 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jun 29, 10:56 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Test Linux').
  • Jun 30, 7:54 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 30, 8:04 AM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jun 30, 8:04 AM UTC: Merged by the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Jun 29, 2025
@camc314
refactor(ast): add AstKind for BindingProperty (#11974)
89494f7
@graphite-app graphite-app bot force-pushed the c/06-29-refactor_ast_add_astkind_for_bindingproperty_ branch from 0d1d373 to 89494f7 Compare June 29, 2025 22:54
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 29, 2025
@camc314 camc314 force-pushed the c/06-29-refactor_ast_add_astkind_for_bindingproperty_ branch from 89494f7 to 54582cb Compare June 30, 2025 07:54
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 30, 2025
@graphite-app graphite-app bot merged commit 54582cb into main Jun 30, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 30, 2025
@graphite-app graphite-app bot deleted the c/06-29-refactor_ast_add_astkind_for_bindingproperty_ branch June 30, 2025 08:04
This was referenced Jul 2, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camchenry camchenry camchenry approved these changes

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter A-linter Area - Linter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camc314 @camchenry